Re: [APC-DEV] 3.0.x vs. 3.1.x

Brian Shire wrote:

Classes have static members and leaving them as leaks results in weird issues http://pecl.php.net/bugs/bug.php?id=8526

Ah, great ;-)

I would have never noticed this particular patch, if not for the SEGV which was due to the fact that you forgot an if(cache_entry->data.file.functions) while cleaning up *all* stuff on the refcount_stack. Which is why there was a double free/segv.

Yes, a session handler with a class static function wouldn't work with APC on - but that's a "known bug", while the bug above was a straight out SEGV :)

Agreed, my memleak vs. SEGV tradeoff isn't so hot. Sorry if I'm making your repeat some history here, but has anyone pursued getting better hook into the Zend shutdown so these items can be taken care of? I realize it's not critical, but interested in hearing your thoughts on it.

Nope, I've never pursued anything so far because most of the time the branch my bugs are on are frozen :) On the other hand, a simple "clean up at end of RSHUTDOWN" function which keeps a stack and efree's stuff at the end could be useful for everyone who has cross-ext memory cleanup issues. Cheers, Gopal -- If I learn from my mistakes, pretty soon I'll know everything