Re: [APC-DEV] Recursive zval patch for review/comments
| From: | Rasmus Lerdorf | Date: | Tue, 06 Feb 2007 22:11:10 +0000 |
| Subject: | Re: [APC-DEV] Recursive zval patch for review/comments | ||
| References: | 1 2 | Groups: | php.apc.dev |
| Request: | Send a blank email to php-apc-dev+get-47@lists.php.net to get a copy of this message | ||
Gopal V wrote:
> Just because zval->refcount == 0 doesn't mean apc_destroy_zval()
> can automatically apc_sma_free() it. This literally corrupts
> prv->next with junk from the previous zend_op and crashes happen
> relatively randomly.
>
> The real problem is that sma_deallocate() acts rather dumb about
> whether it got a valid offset to free or not.
Good find Gopal. Can we try to aim for a public release in the next
couple of weeks? We (and by we I mean Brian and Gopal) have added a
bunch of stuff in the past couple of months with bits and pieces in use
both at Yahoo and Facebook, but the public release is a bit stale.
-Rasmus