Re: [APC-DEV] Recursive zval patch for review/comments
| From: | Brian Shire | Date: | Tue, 06 Feb 2007 22:29:15 +0000 |
| Subject: | Re: [APC-DEV] Recursive zval patch for review/comments | ||
| References: | 1 2 3 | Groups: | php.apc.dev |
| Request: | Send a blank email to php-apc-dev+get-49@lists.php.net to get a copy of this message | ||
On Feb 6, 2007, at 2:11 PM, Rasmus Lerdorf wrote:
Gopal V wrote:I feel like I've been out of sync with APC HEAD lately (in regards to what I'm actively using), I've been trying to get back into sync with this lately and getting a stable release would be great. It would be also nice to start getting the pecl bug emails again, I worry that there's bugs I could look at but am not getting notices, but I'm not sure who to work with to get that going again.Just because zval->refcount == 0 doesn't mean apc_destroy_zval() can automatically apc_sma_free() it. This literally corrupts prv->next with junk from the previous zend_op and crashes happen relatively randomly. The real problem is that sma_deallocate() acts rather dumb about whether it got a valid offset to free or not.Good find Gopal. Can we try to aim for a public release in the next couple of weeks? We (and by we I mean Brian and Gopal) have added a bunch of stuff in the past couple of months with bits and pieces in use both at Yahoo and Facebook, but the public release is a bit stale.
-Rasmus --APC Development Mailing List (http://pecl.php.net/APC) To unsubscribe, visit: http://www.php.net/unsub.php-Brian Shire shire@facebook.com shire@php.net