Bug #17833 Updated: sapi/apache2filter/php_functions.c does not compile

ID: 17833 Updated by: jguilla@attglobal.net Reported By: jguilla@attglobal.net Status: Open Bug Type: Compile Failure Operating System: Linux RH 7.2 PHP Version: 4.2.1 New Comment: Hmmm... I've named the directories to diff incorrectly, but the patch is correct: MODULE_MAGIC_AT_LEAST doesn't work, AP_MODULE_MAGIC_AT_LEAST *seems* to work. Previous Comments: ------------------------------------------------------------------------ [2002-06-19 08:19:21] jguilla@attglobal.net Hi, I seems that the latest version of Apache2 (2.0.39) just issued brokes the compilation of sapi/apache2filter/php_functions.c. It seems like the macro MODULE_MAGIC_AT_LEAST has been obsoleted. I've looked at the apache 2 header files and found that ap_mnh.h defines MODULE_MAGIC_AT_LEAST as garbage. It seems that the macro to use now is AP_MODULE_MAGIC_AT_LEAST. I've modified the source and it seems to compile and run OK, but I'm not neither an apache nor php hacker, so perhaps the "fix" is not complete or is incorrect at all. Please take into account that 2.0.39 has been release to fix a vulnerability, so the issue has to be reviewed by someone whith more knowledge than me. Perhaps you'll find useful this output from diff -U2: --- php-4.2.1/sapi/apache2filter/php_functions.c Sat May 11 11:49:54 2002 +++ php-4.2.1-old/sapi/apache2filter/php_functions.c Wed Jun 19 13:29:27 2002 @@ -91,5 +91,5 @@ ADD_LONG(mtime); ADD_LONG(clength); -#if !MODULE_MAGIC_AT_LEAST(20020506,0) +#if !AP_MODULE_MAGIC_AT_LEAST(20020506,0) ADD_STRING(boundary); #endif Keep up that great work! ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=17833&edit=1