#42060 [Asn->Fbk]: [PATCH] Add pagedResults support and more (PAT18 and PAT19 updated for 5.2.3)

From: Date: Tue, 24 Jul 2007 15:02:01 +0000
Subject: #42060 [Asn->Fbk]: [PATCH] Add pagedResults support and more (PAT18 and PAT19 updated for 5.2.3)
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-115385@lists.php.net to get a copy of this message 
 ID:               42060
 Updated by:       jani@php.net
 Reported By:      iarenuno at eteo dot mondragon dot edu
-Status:           Assigned
+Status:           Feedback
 Bug Type:         LDAP related
 Operating System: Any
 PHP Version:      5.2.3
 Assigned To:      jani
 New Comment:

Some comments about the patch:

1) you need to make the patch apply to latest PHP _5_2 checkout instead
of 5.2.3 sources. (I made some changes in there before I saw this
report)

2) Do you really need to add so many functions for this stuff? And the
naming of those functions isn't very intuitive either.

3) Separate the fixes from the new features. (first fix stuff then add
new..)



Previous Comments:
------------------------------------------------------------------------

[2007-07-21 16:08:17] jani@php.net

New features are not added in bugfix releases so this'll have to wait
til we start the 5.3 branch.

------------------------------------------------------------------------

[2007-07-21 15:52:48] iarenuno at eteo dot mondragon dot edu

Description:
------------
I've taken Pierangelo Masarati's patches (PAT18 and PAT19) and have
updated them to apply to 5.2.3 cleanly (as of today) and fixed a memory
leak.

In addition to it, I've added 4 test scripts based on the examples from
Pierangelo, with a few modifications by me.

I have tested this patch by building PHP with OpenLDAP 2.2.23 libraries
(under Debian Sarge) and run the test scripts against both OpenLDAP
2.2.23 slapd server and MS Active Directory (runnning under W2K3 in W2K3
functional mode). OpenLDAP passes all the tests except passwordPolicy
control extension (because it doesn't support it) and MS Active
Directory passes only the pagedResult test (because it doesn't support
the rest of the implemented controls for which tests exist).

The patch is available at:

http://www.eteo.mondragon.edu/descargas/php-ldap/php-ext-ldap-5.2.3.diff.txt.gz

Could you please add this to the next stable PHP release? I badly need
pagedResults control extension support in PHP :-)

Saludos. Iñaki.



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=42060&edit=1

Thread (75 messages)

« previous php.bugs (#115385) next »