Req #42060 [Com]: [PATCH] LDAP: Add pagedResults support and more

From: Date: Tue, 17 Aug 2010 05:48:51 +0000
Subject: Req #42060 [Com]: [PATCH] LDAP: Add pagedResults support and more
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-153501@lists.php.net to get a copy of this message 
Edit report at http://bugs.php.net/bug.php?id=42060&edit=1

 ID:                 42060
 Comment by:         qmt9z3 at yahoo dot com
 Reported by:        iarenuno at eteo dot mondragon dot edu
 Summary:            [PATCH] LDAP: Add pagedResults support and more
 Status:             Feedback
 Type:               Feature/Change Request
 Package:            *General Issues
 Operating System:   *
 PHP Version:        5CVS, 6CVS (2008-11-01)
 Assigned To:        pajoye
 Block user comment: N

 New Comment:

Hello,
Any plans to fold this into the main stable releases?
Appreciate update on when this is going to become
main stream.

Thanks


Previous Comments:
------------------------------------------------------------------------
[2010-08-04 17:59:30] jeanseb at au-fil-du dot net

I've attached a patch solving this.

In ldap_ctrl_paged_results_resp the 3rd and 4th args are string & int
passed by reference. 

I've defined those args as zval ("zz"), should I change this to string &
int "si" too ?

------------------------------------------------------------------------
[2010-06-16 20:29:05] johannes@php.net

Quick review of the patch shows this part:

	switch (myargcount) {
+		case 4:
+			convert_to_string_ex(&cookie);
+			lcookie.bv_val = Z_STRVAL_PP(&cookie);
+			lcookie.bv_len = Z_STRLEN_PP(&cookie);
+			/* fallthru */

Why is it done this way? Shouldn't "rl|bz" in zend_parse_parameters be
changed to "rl|bs"? I assume the current form will cause trouble with
references and stuff which can't be converted to string (object without
__toString() method)

Didn't do a deeper review.

As we're rolling 5.3.3 very soon i'd keep it out there for now.

------------------------------------------------------------------------
[2010-06-15 21:43:55] pajoye@php.net

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.



------------------------------------------------------------------------
[2010-05-27 15:52:26] jeanseb at au-fil-du dot net

Any feedback on the patch ?

------------------------------------------------------------------------
[2010-05-21 17:35:54] jeanseb at au-fil-du dot net

http://bugs.php.net/patch-display.php?bug_id=42060&patch=php-trunk_ldap-pagination.patch&revision=latest

is against trunk

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    http://bugs.php.net/bug.php?id=42060


-- 
Edit this bug report at http://bugs.php.net/bug.php?id=42060&edit=1

Thread (75 messages)

« previous php.bugs (#153501) next »