#50087 [Opn]: [PATCH] - NSAPI performance improvements
| From: | thetaphi@php.net | Date: | Thu, 12 Nov 2009 15:12:37 +0000 |
| Subject: | #50087 [Opn]: [PATCH] - NSAPI performance improvements | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-144533@lists.php.net to get a copy of this message | ||
ID: 50087
Updated by: thetaphi@php.net
Reported By: yoarvi at gmail dot com
Status: Open
Bug Type: Feature/Change Request
Operating System: Solaris 5.10 (SPARC)
PHP Version: 6SVN-2009-11-05 (SVN)
Assigned To: thetaphi
New Comment:
The patch nsapi3.patch was invalid, because it used an unitialized
"pos" variable. Also it registered the wrong contents for SCRIPT_NAME. I
fixed this.
I will commit soon to 5.3 and trunk.
Previous Comments:
------------------------------------------------------------------------
[2009-11-05 15:58:19] thetaphi@php.net
I will look into it!
------------------------------------------------------------------------
[2009-11-05 10:38:01] yoarvi at gmail dot com
Description:
------------
The PHP NSAPI plugin for Sun Web Server could be made more efficient by
applying the following patches that were previously posted to the
internals mailing list.
1. Use pool_malloc/pool_free instead of MALLOC/FREE
http://marc.info/?l=php-internals&m=125690295631596&w=2
2. Use pool_strdup instead of STRDUP
http://marc.info/?l=php-internals&m=125690359232507&w=2
3. Remove unnecessary strdup calls
http://marc.info/?l=php-internals&m=125690315831950&w=2
4. Avoid unnecessary strlen
http://marc.info/?l=php-internals&m=125690329932150&w=2
Expected result:
----------------
Improved performance.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=50087&edit=1