#50087 [Opn->Csd]: [PATCH] - NSAPI performance improvements

ID: 50087 Updated by: thetaphi@php.net Reported By: yoarvi at gmail dot com -Status: Open +Status: Closed Bug Type: Feature/Change Request Operating System: Solaris 5.10 (SPARC) PHP Version: 6SVN-2009-11-05 (SVN) Assigned To: thetaphi New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Fixed in 5.3 snapshot and trunk snapshot. 5.3.1 will not contain this patch. Previous Comments: ------------------------------------------------------------------------ [2009-11-12 15:19:36] svn@php.net Automatic comment from SVN on behalf of thetaphi Revision: http://svn.php.net/viewvc/?view=revision&revision=290582 Log: Fix bug #50087: NSAPI performance improvements ------------------------------------------------------------------------ [2009-11-12 15:12:37] thetaphi@php.net The patch nsapi3.patch was invalid, because it used an unitialized "pos" variable. Also it registered the wrong contents for SCRIPT_NAME. I fixed this. I will commit soon to 5.3 and trunk. ------------------------------------------------------------------------ [2009-11-05 15:58:19] thetaphi@php.net I will look into it! ------------------------------------------------------------------------ [2009-11-05 10:38:01] yoarvi at gmail dot com Description: ------------ The PHP NSAPI plugin for Sun Web Server could be made more efficient by applying the following patches that were previously posted to the internals mailing list. 1. Use pool_malloc/pool_free instead of MALLOC/FREE http://marc.info/?l=php-internals&m=125690295631596&w=2 2. Use pool_strdup instead of STRDUP http://marc.info/?l=php-internals&m=125690359232507&w=2 3. Remove unnecessary strdup calls http://marc.info/?l=php-internals&m=125690315831950&w=2 4. Avoid unnecessary strlen http://marc.info/?l=php-internals&m=125690329932150&w=2 Expected result: ---------------- Improved performance. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=50087&edit=1