Bug #54040 [NEW]: Logical && where & probably needed in spl_iterators.c

From: sixd Operating system: Generic PHP version: 5.3.6RC1 Package: SPL related Bug Type: Bug Bug description:Logical && where & probably needed in spl_iterators.c Description: ------------ The HP/UX compiler reports the following: "/home/users/cjones/php-5.3.5/ext/spl/spl_iterators.c", line 2742: warning #4277-D: logical AND with a constant, do you mean to use '&'? if ((flags && CIT_FULL_CACHE) != 0 && (intern->u.caching.flags & CIT_FULL_CACHE) == 0) { ^ Similar nearby code uses '&' so the warning is probably accurate. Can this code be reviewed and fixed if the test is incorrect? -- Edit bug report at http://bugs.php.net/bug.php?id=54040&edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=54040&r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=54040&r=trysnapshot53 Try a snapshot (trunk): http://bugs.php.net/fix.php?id=54040&r=trysnapshottrunk Fixed in SVN: http://bugs.php.net/fix.php?id=54040&r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=54040&r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=54040&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=54040&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=54040&r=needscript Try newer version: http://bugs.php.net/fix.php?id=54040&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=54040&r=support Expected behavior: http://bugs.php.net/fix.php?id=54040&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=54040&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=54040&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=54040&r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=54040&r=php4 Daylight Savings: http://bugs.php.net/fix.php?id=54040&r=dst IIS Stability: http://bugs.php.net/fix.php?id=54040&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=54040&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=54040&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=54040&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=54040&r=mysqlcfg