Bug #54040 [Opn->Csd]: Logical && where & probably needed in spl_iterators.c

Edit report at http://bugs.php.net/bug.php?id=54040&edit=1 ID: 54040 Updated by: felipe@php.net Reported by: sixd@php.net Summary: Logical && where & probably needed in spl_iterators.c -Status: Open +Status: Closed Type: Bug Package: SPL related Operating System: Generic PHP Version: 5.3.6RC1 -Assigned To: +Assigned To: felipe Block user comment: N Private report: N New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2011-02-20 17:09:52] felipe@php.net Automatic comment from SVN on behalf of felipe Revision: http://svn.php.net/viewvc/?view=revision&revision=308503 Log: - Fixed bug #54040 (Logical && where & probably needed in spl_iterators) ------------------------------------------------------------------------ [2011-02-18 02:34:42] sixd@php.net Description: ------------ The HP/UX compiler reports the following: "/home/users/cjones/php-5.3.5/ext/spl/spl_iterators.c", line 2742: warning #4277-D: logical AND with a constant, do you mean to use '&'? if ((flags && CIT_FULL_CACHE) != 0 && (intern->u.caching.flags & CIT_FULL_CACHE) == 0) { ^ Similar nearby code uses '&' so the warning is probably accurate. Can this code be reviewed and fixed if the test is incorrect? ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=54040&edit=1