Bug #55473 [Com]: mysql_pconnect leaks file descriptors on reconnect

Edit report at https://bugs.php.net/bug.php?id=55473&edit=1 ID: 55473 Comment by: neweracracker at gmail dot com Reported by: littlesavage at rambler dot ru Summary: mysql_pconnect leaks file descriptors on reconnect Status: Closed Type: Bug Package: MySQL related PHP Version: 5.3.7 Assigned To: andrey Block user comment: N Private report: N New Comment: Maybe its time to apply in 5.3? http://svn.php.net/viewvc?view=revision&revision=315270 Previous Comments: ------------------------------------------------------------------------ [2011-08-22 10:57:44] laruence@php.net Please try using this snapshot: http://snaps.php.net/php5.4-latest.tar.gz For Windows: http://windows.php.net/snapshots/ ------------------------------------------------------------------------ [2011-08-22 10:42:35] andrey@php.net Automatic comment from SVN on behalf of andrey Revision: http://svn.php.net/viewvc/?view=revision&revision=315270 Log: Fix Bug #55473 mysql_pconnect leaks file descriptors on reconnect The fix is for now in 5_4 and trunk, to be merged into 5_3 after 5.3.8 is packaged (expected today). The test case goes to all branches ------------------------------------------------------------------------ [2011-08-22 09:01:22] laruence@php.net and the reason for why this cleanup cound not be done in dtor, is that in dtor, it also clean the content, option, which should not free at that memont, and that is not a dtor time in theory. ------------------------------------------------------------------------ [2011-08-22 08:35:23] laruence@php.net I found this is due to, when doing a reconnect, mysqlnd_connect didn't free the stream. I have submitted a patch, but need georg&andrey&ulf to review first.. ------------------------------------------------------------------------ [2011-08-22 08:33:34] laruence@php.net The following patch has been added/updated: Patch Name: Bug55473.diff Revision: 1314002014 URL: https://bugs.php.net/patch-display.php?bug=55473&patch=Bug55473.diff&revision=1314002014 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55473 -- Edit this bug report at https://bugs.php.net/bug.php?id=55473&edit=1