Bug #55439 [Com]: crypt() returns only the salt for MD5

Edit report at https://bugs.php.net/bug.php?id=55439&edit=1 ID: 55439 Comment by: christoph_m at gmx dot net Reported by: jo at feuersee dot de Summary: crypt() returns only the salt for MD5 Status: Closed Type: Bug Package: *Encryption and hash functions Operating System: Linux PHP Version: 5.3.7RC5 Assigned To: stas Block user comment: N Private report: N New Comment: Ok, strlcat() includes the length for the terminating NUL-Byte. So, the bugfix should be ok. Previous Comments: ------------------------------------------------------------------------ [2011-08-23 17:45:16] christoph_m at gmx dot net Hi, I looked at the code changes. strlcat(passwd, "$", 1); was replaced by strcat(passwd, "$"); In my opinion that is the same behavior as before. Both functions append the string "$" and add the terminating NUL-Character. This is my first look into the PHP-repository and this bugtracker ;) KR christoph ------------------------------------------------------------------------ [2011-08-23 08:09:46] johannes@php.net Automatic comment from SVN on behalf of johannes Revision: http://svn.php.net/viewvc/?view=revision&revision=315338 Log: Merge r315218 - Unbreak crypt() (fix bug #55439) (stas) ------------------------------------------------------------------------ [2011-08-20 09:09:40] pajoye@php.net Yes, we will release 5.3.7pl1 or 5.3.8 ------------------------------------------------------------------------ [2011-08-20 08:48:09] info at onlime dot ch thanks for fixing this (in my eyes) release critical bug. Are you going to release an official 5.3.7pl1 soon? I'm not able to deploy a SVN/snapshot release on our webservers. It simply doesn't look good. Our customers rely on stable PHP releases. I would very much appreciate a pl1 release. ------------------------------------------------------------------------ [2011-08-20 01:32:04] noel dot butler at ausics dot net Thanks stas, confirmed fixed in snapshot 201108200030 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55439 -- Edit this bug report at https://bugs.php.net/bug.php?id=55439&edit=1