Bug #55439 [Com]: crypt() returns only the salt for MD5

Edit report at https://bugs.php.net/bug.php?id=55439&edit=1 ID: 55439 Comment by: info at onlime dot ch Reported by: jo at feuersee dot de Summary: crypt() returns only the salt for MD5 Status: Closed Type: Bug Package: *Encryption and hash functions Operating System: Linux PHP Version: 5.3.7RC5 Assigned To: stas Block user comment: N Private report: N New Comment: thanks for fixing this (in my eyes) release critical bug. Are you going to release an official 5.3.7pl1 soon? I'm not able to deploy a SVN/snapshot release on our webservers. It simply doesn't look good. Our customers rely on stable PHP releases. I would very much appreciate a pl1 release. Previous Comments: ------------------------------------------------------------------------ [2011-08-20 01:32:04] noel dot butler at ausics dot net Thanks stas, confirmed fixed in snapshot 201108200030 ------------------------------------------------------------------------ [2011-08-19 22:50:07] stas@php.net This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. fixed, thanks ------------------------------------------------------------------------ [2011-08-19 22:49:11] stas@php.net Automatic comment from SVN on behalf of stas Revision: http://svn.php.net/viewvc/?view=revision&revision=315218 Log: Unbreak crypt() (fix bug #55439) # If you want to remove static analyser messages, be my guest, # but please run unit tests after ------------------------------------------------------------------------ [2011-08-19 22:19:40] stas@php.net Confirming, some very recent update broke it - right now unit tests fail on SVN. I wonder if nobody run it before release? ------------------------------------------------------------------------ [2011-08-19 21:32:01] jo at feuersee dot de Uhm ok the PHP code wasn't correct but I think you get the point: If crypt() only stores the salt then crypt($pw, $salt) will return the salt and comparing this to $pw is useless as the salt is a constant regardless of $pw. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55439 -- Edit this bug report at https://bugs.php.net/bug.php?id=55439&edit=1