Bug #55439 [PATCH]: crypt() returns only the salt for MD5

Edit report at https://bugs.php.net/bug.php?id=55439&edit=1 ID: 55439 Patch added by: test@test.cz Reported by: jo at feuersee dot de Summary: crypt() returns only the salt for MD5 Status: Closed Type: Bug Package: *Encryption and hash functions Operating System: Linux PHP Version: 5.3.7RC5 Assigned To: stas Block user comment: N Private report: N New Comment: The following pull request has been associated: Patch Name: Extract functions to classes On GitHub: https://github.com/php/web-master/pull/12 Patch: https://github.com/php/web-master/pull/12.patch Previous Comments: ------------------------------------------------------------------------ [2013-11-17 09:36:51] laruence@php.net Automatic comment on behalf of stas Revision: http://git.php.net/?p=php-src.git;a=commit;h=4f980905a0bff94807ea07cb897c0e4cd4e6b83f Log: Unbreak crypt() (fix bug #55439) # If you want to remove static analyser messages, be my guest, # but please run unit tests after ------------------------------------------------------------------------ [2012-07-24 23:40:19] rasmus@php.net Automatic comment on behalf of stas Revision: http://git.php.net/?p=php-src.git;a=commit;h=4f980905a0bff94807ea07cb897c0e4cd4e6b83f Log: Unbreak crypt() (fix bug #55439) # If you want to remove static analyser messages, be my guest, # but please run unit tests after ------------------------------------------------------------------------ [2012-04-18 09:49:13] laruence@php.net Automatic comment on behalf of stas Revision: http://git.php.net/?p=php-src.git;a=commit;h=4f980905a0bff94807ea07cb897c0e4cd4e6b83f Log: Unbreak crypt() (fix bug #55439) # If you want to remove static analyser messages, be my guest, # but please run unit tests after ------------------------------------------------------------------------ [2011-08-23 18:44:53] christoph_m at gmx dot net Ok, strlcat() includes the length for the terminating NUL-Byte. So, the bugfix should be ok. ------------------------------------------------------------------------ [2011-08-23 17:45:16] christoph_m at gmx dot net Hi, I looked at the code changes. strlcat(passwd, "$", 1); was replaced by strcat(passwd, "$"); In my opinion that is the same behavior as before. Both functions append the string "$" and add the terminating NUL-Character. This is my first look into the PHP-repository and this bugtracker ;) KR christoph ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55439 -- Edit this bug report at https://bugs.php.net/bug.php?id=55439&edit=1