Req #55788 [Com]: test redirects should abide SHOW_ONLY_GROUPS in run-tests.php
| From: | tyrael@php.net | Date: | Wed, 28 Sep 2011 23:18:47 +0000 |
| Subject: | Req #55788 [Com]: test redirects should abide SHOW_ONLY_GROUPS in run-tests.php | ||
| References: | 1 | Groups: | php.bugs php.qa |
| Request: | Send a blank email to php-bugs+get-163960@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=55788&edit=1
ID: 55788
Comment by: tyrael@php.net
Reported by: tyrael@php.net
Summary: test redirects should abide SHOW_ONLY_GROUPS in
run-tests.php
Status: Open
Type: Feature/Change Request
Package: Testing related
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
as Hannes asked, I update the patch with the following:
the groupname for redirect is REDIRECT, as it is more clear what it does than -->
I also updated the code, so now it prints
REDIRECT $tests ($tested [$tested_file]) begin\n
instead of
--> $tests ($tested [$tested_file]) begin\n
so the group name, and the ouput is consistent as for the other groupnames.
I also updated the help to list the possible values for -g (aka SHOW_ONLY_GROUPS)
Previous Comments:
------------------------------------------------------------------------
[2011-09-26 21:55:08] tyrael@php.net
Description:
------------
currently the test redirects(show_redirect_start() and show_redirect_ends()) will
always print two lines to the output, ignoring the value of SHOW_ONLY_GROUPS.
I think that it would be more consistent, if those lines could be controlled the
same way, as we do with everything else.
this change would only noticeable for those who run the test suite with custom
options (passing the SHOW_ONLY_GROUPS environment variable to make test or the
argument -g to run-tests.php).
the attached patch is pretty straightforward, you can pass the ---> if you need
the ---> lines in your testsuite output.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=55788&edit=1