Req->Bug #55788 [Opn->Csd]: test redirects should abide SHOW_ONLY_GROUPS in run-tests.php

Edit report at https://bugs.php.net/bug.php?id=55788&edit=1 ID: 55788 Updated by: felipe@php.net Reported by: tyrael@php.net Summary: test redirects should abide SHOW_ONLY_GROUPS in run-tests.php -Status: Open +Status: Closed -Type: Feature/Change Request +Type: Bug Package: Testing related PHP Version: Irrelevant -Assigned To: +Assigned To: felipe Block user comment: N Private report: N New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2011-11-26 17:56:29] felipe@php.net Automatic comment from SVN on behalf of felipe Revision: http://svn.php.net/viewvc/?view=revision&revision=319964 Log: - Fixed bug #55788 (test redirects should abide SHOW_ONLY_GROUPS in run-tests.php) patch by: tyrael at php.net ------------------------------------------------------------------------ [2011-09-28 23:20:15] tyrael@php.net The following patch has been added/updated: Patch Name: run-tests.php.diff Revision: 1317252015 URL: https://bugs.php.net/patch-display.php?bug=55788&patch=run-tests.php.diff&revision=1317252015 ------------------------------------------------------------------------ [2011-09-28 23:18:46] tyrael@php.net as Hannes asked, I update the patch with the following: the groupname for redirect is REDIRECT, as it is more clear what it does than --> I also updated the code, so now it prints REDIRECT $tests ($tested [$tested_file]) begin\n instead of --> $tests ($tested [$tested_file]) begin\n so the group name, and the ouput is consistent as for the other groupnames. I also updated the help to list the possible values for -g (aka SHOW_ONLY_GROUPS) ------------------------------------------------------------------------ [2011-09-26 21:55:08] tyrael@php.net Description: ------------ currently the test redirects(show_redirect_start() and show_redirect_ends()) will always print two lines to the output, ignoring the value of SHOW_ONLY_GROUPS. I think that it would be more consistent, if those lines could be controlled the same way, as we do with everything else. this change would only noticeable for those who run the test suite with custom options (passing the SHOW_ONLY_GROUPS environment variable to make test or the argument -g to run-tests.php). the attached patch is pretty straightforward, you can pass the ---> if you need the ---> lines in your testsuite output. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55788&edit=1