Bug #55371 [Asn]: Function get_magic_quotes_gpc() is deprecated

Edit report at https://bugs.php.net/bug.php?id=55371&edit=1 ID: 55371 Updated by: pajoye@php.net Reported by: thbley at gmail dot com Summary: Function get_magic_quotes_gpc() is deprecated Status: Assigned Type: Bug Package: Safe Mode/open_basedir Operating System: Win7 6.1.7600 PHP Version: 5.4.0alpha3 Assigned To: dsp Block user comment: N Private report: N New Comment: Let me clarify this pointer. Getter should not raise any warning. Setters do. Previous Comments: ------------------------------------------------------------------------ [2011-11-15 13:01:45] david dot zuelke at bitextender dot com A warning definitely is a bad idea, it makes it impossible to write portable code to detect magic quotes without version check stunts. It's fine if the two functions simply return false forever, there's not even a need to remove them as they don't do any harm whatsoever. ------------------------------------------------------------------------ [2011-11-15 12:58:20] pajoye@php.net Hi David, please do it, I do not have the time to do it before RC2. Cheers, ------------------------------------------------------------------------ [2011-11-14 11:14:00] bjori@php.net Throwing any kind of warnings for the getters is a cruel punishment targetting the people who were actually dealing with the problem we gave them in the first place. ------------------------------------------------------------------------ [2011-11-12 21:57:29] tyrael@php.net Just my 2 cents: I think that raising an E_DEPRECATED now is better, if we want to remove the get methods with the major/minor version after 5.4. ------------------------------------------------------------------------ [2011-11-12 12:12:01] david dot zuelke at bitextender dot com According to several mailing list threads I've searched, it should not give a deprecation warning. So it's not a documentation problem but a bug. The attached patch fixes the problem (uses PHP_FE instead of PHP_DEP_FE for get_magic_quotes_gpc() and get_magic_quotes_runtime()) and adds and updates tests accordingly. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55371 -- Edit this bug report at https://bugs.php.net/bug.php?id=55371&edit=1