Bug #55371 [Asn->Csd]: get_magic_quotes_gpc() throws deprecation warning
| From: | dsp@php.net | Date: | Tue, 15 Nov 2011 13:27:14 +0000 |
| Subject: | Bug #55371 [Asn->Csd]: get_magic_quotes_gpc() throws deprecation warning | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-165162@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=55371&edit=1
ID: 55371
Updated by: dsp@php.net
Reported by: thbley at gmail dot com
Summary: get_magic_quotes_gpc() throws deprecation warning
-Status: Assigned
+Status: Closed
Type: Bug
Package: Safe Mode/open_basedir
Operating System: Win7 6.1.7600
PHP Version: 5.4.0alpha3
Assigned To: dsp
Block user comment: N
Private report: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Thanks david, patch applied.
Previous Comments:
------------------------------------------------------------------------
[2011-11-15 13:22:42] dsp@php.net
Automatic comment from SVN on behalf of dsp
Revision: http://svn.php.net/viewvc/?view=revision&revision=319249
Log: Fixed bug #55371 (get_magic_quotes_gpc() throws deprecation warning.)
Patch by David Zuelke <david dot zuelke at bitextender dot com>
------------------------------------------------------------------------
[2011-11-15 13:09:43] pajoye@php.net
Let me clarify this pointer. Getter should not raise any warning. Setters do.
------------------------------------------------------------------------
[2011-11-15 13:01:45] david dot zuelke at bitextender dot com
A warning definitely is a bad idea, it makes it impossible to write portable code
to detect magic quotes without version check stunts. It's fine if the two
functions simply return false forever, there's not even a need to remove them as
they don't do any harm whatsoever.
------------------------------------------------------------------------
[2011-11-15 12:58:20] pajoye@php.net
Hi David,
please do it, I do not have the time to do it before RC2.
Cheers,
------------------------------------------------------------------------
[2011-11-14 11:14:00] bjori@php.net
Throwing any kind of warnings for the getters is a cruel punishment targetting
the people who were actually dealing with the problem we gave them in the first
place.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=55371
--
Edit this bug report at https://bugs.php.net/bug.php?id=55371&edit=1