Bug #60596 [NEW]: Code Cleanup Removing Superfluous If Statement

From: ircmaxell Operating system: Any PHP version: trunk-SVN-2011-12-22 (SVN) Package: SPL related Bug Type: Bug Bug description:Code Cleanup Removing Superfluous If Statement Description: ------------ The switch statement for spl_offset_convert_to_long has a superfluous IF statement that is unnecessary (and causes an unnecessary Z_TYPE_P macro expansion). I've attached a patch which refactors this to remove the if statement. I wasn't sure to classify this as a bug or not since it doesn't affect PHP at all, but it's just code-cleanup. Anthony -- Edit bug report at https://bugs.php.net/bug.php?id=60596&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=60596&r=trysnapshot54 Try a snapshot (PHP 5.3): https://bugs.php.net/fix.php?id=60596&r=trysnapshot53 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=60596&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=60596&r=fixed Fixed in SVN and need be documented: https://bugs.php.net/fix.php?id=60596&r=needdocs Fixed in release: https://bugs.php.net/fix.php?id=60596&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=60596&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=60596&r=needscript Try newer version: https://bugs.php.net/fix.php?id=60596&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=60596&r=support Expected behavior: https://bugs.php.net/fix.php?id=60596&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=60596&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=60596&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=60596&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=60596&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=60596&r=dst IIS Stability: https://bugs.php.net/fix.php?id=60596&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=60596&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=60596&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=60596&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=60596&r=mysqlcfg