Bug #60596 [Opn->Csd]: Code Cleanup Removing Superfluous If Statement
Edit report at https://bugs.php.net/bug.php?id=60596&edit=1
ID: 60596
Updated by: nikic@php.net
Reported by: ircmaxell@php.net
Summary: Code Cleanup Removing Superfluous If Statement
-Status: Open
+Status: Closed
Type: Bug
Package: SPL related
Operating System: Any
PHP Version: trunk-SVN-2011-12-22 (SVN)
-Assigned To:
+Assigned To: nikic
Block user comment: N
Private report: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2012-03-04 13:52:41] nikic@php.net
Automatic comment from SVN on behalf of nikic
Revision: http://svn.php.net/viewvc/?view=revision&revision=323863
Log: Fix bug #60596: Code Cleanup Removing Superfluous If Statement
Cleanup only, no function change. Patch by ircmaxell.
------------------------------------------------------------------------
[2011-12-22 20:15:25] ircmaxell@php.net
Description:
------------
The switch statement for spl_offset_convert_to_long has a superfluous IF statement
that is unnecessary (and causes an unnecessary Z_TYPE_P macro expansion).
I've attached a patch which refactors this to remove the if statement.
I wasn't sure to classify this as a bug or not since it doesn't affect PHP at all,
but it's just code-cleanup.
Anthony
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=60596&edit=1
Thread (2 messages)