Edit report at https://bugs.php.net/bug.php?id=63242&edit=1
ID: 63242
Updated by: laruence@php.net
Reported by: pascal dot chevrel at free dot fr
Summary: Default error page in PHP built-in web server uses
outdated html/css
Status: Open
Type: Feature/Change Request
Package: Built-in web server
Operating System: Linux
PHP Version: 5.4.7
Block user comment: N
Private report: N
New Comment:
@pascal, thanks
it will be better if you can improve the skeleton keep the "looks"
Previous Comments:
------------------------------------------------------------------------
[2012-10-09 08:37:57] pascal dot chevrel at free dot fr
Reeze, not sure I understand what you mean. For sure, I am in no way saying that the integrated web
server should be used in production.
You seem to be of the opinion that since it is not targetting production, it is ok that it is using
obsolete HTML/CSS and looks like a 404 page from the 90's, I disagree, there is no reason to
use complex sub-quality HTML/CSS, especially since it gives poor visual result.
My patch simplifies the code used (less lines of code) while making the error page a bit more decent
in terms of layout.
I am happy to make compromises on this patch and revert the color to use the same blue color as
before if you wish, using correct typography/alignment and simpler html/css code in the source code
would already be a win for both consumers (web developpers that see this page during their
developement) and the code base I think.
------------------------------------------------------------------------
[2012-10-09 05:12:41] reeze@php.net
It's nice to have modern, but the appearance should be consist on PHP
itself(VI).
PHP use the BLUE a lot, kind of the color of PHP.
as the color yellow, It looks like an error page of django :)
and the built-in server is just for testing purpose, If possible, I'd PHP
redesign its Visual Identity System to be more modern.
And, yes there is a PHP.net alpha there: http://www.php.net/my.php (enable it at
the bottom). but seems didn't active for a long time.
------------------------------------------------------------------------
[2012-10-08 17:53:00] pascal dot chevrel at free dot fr
Here is a after/before screenshot:
http://chevrel.org/images/phpbugs/bug63242.png
Note that I chose yellow for the error header instead of blue because this is the color used in the
terminal for such errors, blue is not usually an error associated to errors.
------------------------------------------------------------------------
[2012-10-08 17:41:00] pascal dot chevrel at free dot fr
Description:
------------
The default error page in the built-in webserver is very ugly. Looking at the history of the file in
the git repository, these styles and html were copied from the phpinfo styling created in 2002 with
CSS selectors that had Netscape 4/IE4 compatibility in mind.
Appearances matter :) It makes this new PHP feature look already outdated.
I am going to attach a patch that:
* will make it look a bit more modern and works in responsive mode too
* will remove unused css rules from the code
* will add an html5 doctype to the error page
* will remove unnecesary html attributes in html5
(I noticed that there are 2 tests in the sapi/cli/tests folder that reproduce some of this html, I
don't know how tests work for php but I can give a shot at updating the expected results of the
tests in the patch if required)
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=63242&edit=1