Edit report at https://bugs.php.net/bug.php?id=63242&edit=1
ID: 63242
Updated by: laruence@php.net
Reported by: pascal dot chevrel at free dot fr
Summary: Default error page in PHP built-in web server uses
outdated html/css
-Status: Open
+Status: Closed
Type: Feature/Change Request
Package: Built-in web server
Operating System: Linux
PHP Version: 5.4.7
-Assigned To:
+Assigned To: laruence
Block user comment: N
Private report: N
New Comment:
The fix for this bug has been committed.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
thanks for your help.
and you can open a new entry about improve the looks, :)
thanks
Previous Comments:
------------------------------------------------------------------------
[2012-10-10 07:15:00] pascal dot chevrel at free dot fr
Ok, here is an updated patch, it only updates the structure and tests and it reproduces the styles
copied from the 2002 file. To make it absolutely identical, I had to add a margin-top:0 rule to h1
so as to emulate quirks mode in browsers for html3 documents.
------------------------------------------------------------------------
[2012-10-10 03:46:16] laruence@php.net
I think we can split this into two patch:
1. keep the looks unchanged, and improve the skeleton
2. improve the looks
the first one could easy to be accepted.
------------------------------------------------------------------------
[2012-10-09 20:28:56] pascal dot chevrel at free dot fr
btw, I attached a patch to the bug but in case you prefer a Pull Request on github, just tell me. I
don't know what process is preferred today for PHP patches.
------------------------------------------------------------------------
[2012-10-09 14:50:01] reeze@php.net
@Pascal,
I like the idea to make it more modern, I just think the color you choose it not
well consist with PHP's blue color and visual identity.
------------------------------------------------------------------------
[2012-10-09 12:02:24] pascal dot chevrel at free dot fr
I just attached an updated patch that restores the blue color.
You can see the result here:
http://chevrel.org/images/phpbugs/bug63242v2.png
I also compiled php locally and ran the tests, there were 2 tests failing because of the new patch,
I updated these two tests in my patch.
Tell me if you need updates to this patch, thanks.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=63242
--
Edit this bug report at https://bugs.php.net/bug.php?id=63242&edit=1