Edit report at https://bugs.php.net/bug.php?id=63228&edit=1
ID: 63228
User updated by: glen at delfi dot ee
Reported by: glen at delfi dot ee
Summary: -Werror=format-security error in lsapi code
-Status: Closed
+Status: Assigned
Type: Bug
Package: Compile Failure
PHP Version: 5.4.7
Assigned To: gwang
Block user comment: N
Private report: N
New Comment:
this is idiotic already. why are you closing this bug with description it is
fixed when it is not?!
as wrigint of this note (2012-12-29), downloads page says:
PHP 5.4.10 (Current stable)
Complete Source Code
PHP 5.4.10 (tar.bz2) [10,885Kb] - 20 Dec 2012
md5: cb716b657a30570b9b468b9e7bc551a1
and the patch is NOT APPLIED in that release
even if you commit is included in php repo, THE COMMIT IS NOT APPEARING in 5.4
series. re-merge the commit or cherry pick it!
last commit to the file in 5.4 is 4 months ago, while your commit is 3 months
old
https://github.com/php/php-src/blob/PHP-5.4.10/sapi/litespeed/lsapi_main.chttps://github.com/php/php-src/commits/PHP-5.4.10/sapi/litespeed/lsapi_main.chttp://i.imgur.com/uqlx3.png
Previous Comments:
------------------------------------------------------------------------
[2012-12-28 17:04:44] gwang@php.net
Thank you for your bug report. This issue has already been fixed
in the latest released version of PHP, which you can download at
http://www.php.net/downloads.php
------------------------------------------------------------------------
[2012-12-18 07:39:31] glen at delfi dot ee
step by step proof that it's not fixed:
$ wget http://php.net/get/php-5.4.9.tar.bz2/from/this/mirror
-O php-
5.4.9.tar.bz2
$ tar xjf php-5.4.9.tar.bz2
$ grep -n usage php-5.4.9/sapi/litespeed/lsapi_main.c
586:static void cli_usage( TSRMLS_D )
588: static const char * usage =
606: php_printf( usage );
744: cli_usage(TSRMLS_C);
788: cli_usage(TSRMLS_C);
------------------------------------------------------------------------
[2012-12-17 17:57:50] glen at delfi dot ee
hey!
this is not funny! the commit is not appearing in 5.4.9 release tarball either,
please reply where did you commit the fix instead closing it again silently...
------------------------------------------------------------------------
[2012-11-16 18:01:01] gwang@php.net
Thank you for your bug report. This issue has already been fixed
in the latest released version of PHP, which you can download at
http://www.php.net/downloads.php
------------------------------------------------------------------------
[2012-11-09 09:24:45] glen at delfi dot ee
code still not fixed in 5.4.8, what branch did you fix?! :o
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=63228--
Edit this bug report at https://bugs.php.net/bug.php?id=63228&edit=1