Bug #63228 [Csd]: -Werror=format-security error in lsapi code

Edit report at https://bugs.php.net/bug.php?id=63228&edit=1 ID: 63228 User updated by: glen at delfi dot ee Reported by: glen at delfi dot ee Summary: -Werror=format-security error in lsapi code Status: Closed Type: Bug Package: Compile Failure PHP Version: 5.4.7 Assigned To: gwang Block user comment: N Private report: N New Comment: thanks! finally! Previous Comments: ------------------------------------------------------------------------ [2013-01-08 03:48:42] aharvey@php.net Cherry picked and remerged, since this was clearly intended for 5.4: https://github.com/php/php-src/commit/9c52d09ebc62683f26338123bcda8068f162541d This has missed 5.4.11, but should be in PHP 5.4.12. ------------------------------------------------------------------------ [2013-01-08 03:47:43] aharvey@php.net Automatic comment on behalf of gwang Revision: http://git.php.net/?p=php-src.git;a=commit;h=9c52d09ebc62683f26338123bcda8068f162541d Log: sapi/litespeed/lsapi_main.c: Fix bug #63228 ------------------------------------------------------------------------ [2012-12-29 14:28:36] glen at delfi dot ee this is idiotic already. why are you closing this bug with description it is fixed when it is not?! as wrigint of this note (2012-12-29), downloads page says: PHP 5.4.10 (Current stable) Complete Source Code PHP 5.4.10 (tar.bz2) [10,885Kb] - 20 Dec 2012 md5: cb716b657a30570b9b468b9e7bc551a1 and the patch is NOT APPLIED in that release even if you commit is included in php repo, THE COMMIT IS NOT APPEARING in 5.4 series. re-merge the commit or cherry pick it! last commit to the file in 5.4 is 4 months ago, while your commit is 3 months old https://github.com/php/php-src/blob/PHP-5.4.10/sapi/litespeed/lsapi_main.c https://github.com/php/php-src/commits/PHP-5.4.10/sapi/litespeed/lsapi_main.c http://i.imgur.com/uqlx3.png ------------------------------------------------------------------------ [2012-12-28 17:04:44] gwang@php.net Thank you for your bug report. This issue has already been fixed in the latest released version of PHP, which you can download at http://www.php.net/downloads.php ------------------------------------------------------------------------ [2012-12-18 07:39:31] glen at delfi dot ee step by step proof that it's not fixed: $ wget http://php.net/get/php-5.4.9.tar.bz2/from/this/mirror -O php- 5.4.9.tar.bz2 $ tar xjf php-5.4.9.tar.bz2 $ grep -n usage php-5.4.9/sapi/litespeed/lsapi_main.c 586:static void cli_usage( TSRMLS_D ) 588: static const char * usage = 606: php_printf( usage ); 744: cli_usage(TSRMLS_C); 788: cli_usage(TSRMLS_C); ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=63228 -- Edit this bug report at https://bugs.php.net/bug.php?id=63228&edit=1