Req #61853 [Com]: Use of non-deprecated functions

Edit report at https://bugs.php.net/bug.php?id=61853&edit=1 ID: 61853 Comment by: ab@php.net Reported by: etienne at lamaisondebarbie dot ch Summary: Use of non-deprecated functions Status: Feedback Type: Feature/Change Request Package: LDAP related Operating System: Debian testing PHP Version: master-Git-2012-04-25 (Git) Assigned To: ab Block user comment: N Private report: N New Comment: I'm still testing the functionality in whole. Please add also some tests for what you did so far. Previous Comments: ------------------------------------------------------------------------ [2013-02-22 15:19:43] ab@php.net I've tested your last patch with ifdefs, the code compiles at least :) But the version check isn't smart enough, thus I get errors when compiling with openldap 2.3.48, but it pass though with 2.4.33 . That's because both have api version 3001. So that means for one that some more #ifdef are needed there, and second - that at least for what I see we should check exact by lib version, no by api version. And the point lays somewhere betwee 2.3.48 and 2.4.33 :) ------------------------------------------------------------------------ [2012-04-26 10:13:31] etienne at lamaisondebarbie dot ch I did a new patch that bundle both patch and use #ifdef. I'm not sure about LDAP_API_VERSION, but > 2000 seems to be ok. Also, in the original version used ldap_modify_ext_s, I changed to ldap_modify_s. ------------------------------------------------------------------------ [2012-04-26 09:29:04] pajoye@php.net Hi! The patch looks good. However I would prefer to add some #ifdef and to use the old versions when an old ldap client is used. We may as well drop these old versions in php-next tho'. ------------------------------------------------------------------------ [2012-04-25 20:37:57] etienne at lamaisondebarbie dot ch Description: ------------ This patch aims to remove usage of deprecated ldap function. I did change the php_ldap_do_search to use ldap_search_ext and ldap_search_ext_s. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=61853&edit=1