Edit report at https://bugs.php.net/bug.php?id=61853&edit=1
ID: 61853
User updated by: etienne at lamaisondebarbie dot ch
Reported by: etienne at lamaisondebarbie dot ch
Summary: Use of non-deprecated functions
Status: Assigned
Type: Feature/Change Request
Package: LDAP related
Operating System: Debian testing
PHP Version: master-Git-2012-04-25 (Git)
Assigned To: ab
Block user comment: N
Private report: N
New Comment:
Here is the patch including patch from #61853 and #61921 with some helper functions in file
ldap_dev_utils.c. This goes against current php-src head.
Previous Comments:
------------------------------------------------------------------------
[2013-02-22 21:19:10] etienne at lamaisondebarbie dot ch
Yes you are right, ldap_control_create is not available everywhere (not in older libldap and not in
winldap). I used it naturally and forget to check for this one.
It has to be re-implemented into php-ldap, I'll do as soon as possible.
------------------------------------------------------------------------
[2013-02-22 17:39:35] ab@php.net
Yes, the code from both patches (#61921 and this one) compiles fine, but there is a link error with
2.3.42 (not 2.3.48, my bad), it can't find ldap_control_create. The latest, 2.4.33, compiles
good and tests pass. Only one test fails for me ext\ldap\tests\ldap_sasl_bind_basic.phpt , but
that's disregarding of with or without patch. That's may be because of the server
configuration. If you mean no new test need to be added, so be.
About that #ifdef - it's not about server but client libs. IMHO, there are still enough
"stable" distro versions in use, like centos5 and so on, which have older openldap by
default. At the end of the day, it's not a big deal to put just a bit more appropriate checks
and be compatible with older client libs. As it's almost done now anyway :) It's just a
bit confusing both 2.3 and 2.4 series having the api version of 3001, but from the other side - this
way the devs mean it stands not very far from each other.
------------------------------------------------------------------------
[2013-02-22 16:57:22] etienne at lamaisondebarbie dot ch
And anyway, *_ext family was designed in 1998 and first implemented in libldap in 1999. ldap_search
was tagged as deprecated in 2006. There is no reason to put those ifdef in the first place, I
don't think people like to have 6 years old unmaintained code running on their webserver. On
windows those functions are supported since Windows 2k ...
------------------------------------------------------------------------
[2013-02-22 16:37:38] etienne at lamaisondebarbie dot ch
Does php-ldap compile under 2.3.48 without my patch ? (tests are already available in tests
directory).
------------------------------------------------------------------------
[2013-02-22 15:21:10] ab@php.net
I'm still testing the functionality in whole. Please add also some tests for what you did so
far.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61853
--
Edit this bug report at https://bugs.php.net/bug.php?id=61853&edit=1