Req #64639 [PATCH]: Add third parameter to nl2br
| From: | krakjoe@php.net | Date: | Wed, 17 Apr 2013 19:44:35 +0000 |
| Subject: | Req #64639 [PATCH]: Add third parameter to nl2br | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-178513@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=64639&edit=1
ID: 64639
Patch added by: krakjoe@php.net
Reported by: valentiny510 at yahoo dot es
Summary: Add third parameter to nl2br
Status: Open
Type: Feature/Change Request
Package: *General Issues
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
The following patch has been added/updated:
Patch Name: nl2br_additional_parameter
Revision: 1366227875
URL: https://bugs.php.net/patch-display.php?bug=64639&patch=nl2br_additional_parameter&revision=1366227875
Previous Comments:
------------------------------------------------------------------------
[2013-04-12 02:12:27] valentiny510 at yahoo dot es
Description:
------------
The name "nl2br" for somebody who doesn't know php very well, suggest that actually
replace "nl" with "br" but is not true. The name of the function function should
be "nl2nl+br"
I think it should have a third parameter like $replace, and actually Replace the nl with br
I have some clients who used this function inside pre with horrible result.
Anyway, I think it will be more usefull this
nl2br ($string, true/false, $replace = true/false)
than
preg_replace('#([\r?\n]+)#', '<br>', $string) or
str_replace(array("\r\n", "\r", "\n"), '<br>',
$string)
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=64639&edit=1