Req #64639 [Com]: Add third parameter to nl2br

Edit report at https://bugs.php.net/bug.php?id=64639&edit=1 ID: 64639 Comment by: octavianmarinescu at tavi dot ro Reported by: valentiny510 at yahoo dot es Summary: Add third parameter to nl2br Status: Open Type: Feature/Change Request Package: *General Issues PHP Version: Irrelevant Block user comment: N Private report: N New Comment: yes would be a shorter and more elegant solution nl2br($str, false, true); nice and clean.. Previous Comments: ------------------------------------------------------------------------ [2013-04-17 19:44:35] krakjoe@php.net The following patch has been added/updated: Patch Name: nl2br_additional_parameter Revision: 1366227875 URL: https://bugs.php.net/patch-display.php?bug=64639&patch=nl2br_additional_parameter&revision=1366227875 ------------------------------------------------------------------------ [2013-04-12 02:12:27] valentiny510 at yahoo dot es Description: ------------ The name "nl2br" for somebody who doesn't know php very well, suggest that actually replace "nl" with "br" but is not true. The name of the function function should be "nl2nl+br" I think it should have a third parameter like $replace, and actually Replace the nl with br I have some clients who used this function inside pre with horrible result. Anyway, I think it will be more usefull this nl2br ($string, true/false, $replace = true/false) than preg_replace('#([\r?\n]+)#', '<br>', $string) or str_replace(array("\r\n", "\r", "\n"), '<br>', $string) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=64639&edit=1