Bug #66239 [Opn]: Fpm won't error_log to syslog, php works fine
| From: | krakjoe@php.net | Date: | Fri, 06 Dec 2013 11:59:58 +0000 |
| Subject: | Bug #66239 [Opn]: Fpm won't error_log to syslog, php works fine | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-183185@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=66239&edit=1
ID: 66239
Updated by: krakjoe@php.net
Reported by: sjon at hortensius dot net
Summary: Fpm won't error_log to syslog, php works fine
Status: Open
Type: Bug
Package: FPM related
Operating System: archlinux
PHP Version: 5.5.6
Block user comment: N
Private report: N
New Comment:
I think the first patch is correct, I don't see when you would want syslog expanded (usually to
a non-existent path) in any case ...
Alternate patch attached anyway ...
Previous Comments:
------------------------------------------------------------------------
[2013-12-06 11:56:56] krakjoe@php.net
The following patch has been added/updated:
Patch Name: fpm-syslog-bug.patch
Revision: 1386331016
URL: https://bugs.php.net/patch-display.php?bug=66239&patch=fpm-syslog-bug.patch&revision=1386331016
------------------------------------------------------------------------
[2013-12-06 11:55:37] krakjoe@php.net
The following patch has been added/updated:
Patch Name: fpm-syslog-bug-alternate.patch
Revision: 1386330937
URL: https://bugs.php.net/patch-display.php?bug=66239&patch=fpm-syslog-bug-alternate.patch&revision=1386330937
------------------------------------------------------------------------
[2013-12-06 11:47:09] krakjoe@php.net
Why depend on wp->config->chroot ?
Can you think of a case where it is reasonable for "syslog" to be expanded ?
------------------------------------------------------------------------
[2013-12-06 09:52:20] tony2001@php.net
But why do you change fpm_evaluate_full_path()? It's used everywhere and
php_value/php_admin_value is just one use case.
I believe you should be changing the checks in this 'if' instead:
/* env[], php_value[], php_admin_values[] */
if (!wp->config->chroot) {
------------------------------------------------------------------------
[2013-12-06 08:04:36] krakjoe@php.net
fpm fails to check for "syslog" before expanding the path, patch attached
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=66239
--
Edit this bug report at https://bugs.php.net/bug.php?id=66239&edit=1