Bug #66840 [NEW]: use of undeclared identifiers 'DEFAULT_RENEG_LIMIT', 'DEFAULT_RENEG_WINDOW'

From: php-bugs-2014 at ryandesign dot com Operating system: OS X 10.9.2 PHP version: 5.6.0alpha3 Package: OpenSSL related Bug Type: Bug Bug description:use of undeclared identifiers 'DEFAULT_RENEG_LIMIT', 'DEFAULT_RENEG_WINDOW' Description: ------------ Hello, I'm the maintainer of php in MacPorts. I'm trying to update our php56 ports to version 5.6.0alpha3. The openssl extension is failing to build, as follows: /opt/local/var/macports/build/_Users_rschmidt_macports_dports_lang_php/php56-openssl/work/php-5.6.0alpha3/ext/openssl/xp_ssl.c:390:15: error: use of undeclared identifier 'DEFAULT_RENEG_LIMIT' long limit = DEFAULT_RENEG_LIMIT; ^ /opt/local/var/macports/build/_Users_rschmidt_macports_dports_lang_php/php56-openssl/work/php-5.6.0alpha3/ext/openssl/xp_ssl.c:391:16: error: use of undeclared identifier 'DEFAULT_RENEG_WINDOW' long window = DEFAULT_RENEG_WINDOW; ^ 2 errors generated. make: *** [xp_ssl.lo] Error 1 Note that we're building the extension separately from php, using phpize and a separate configure and make. 5.6.0alpha2 built fine. DEFAULT_RENEG_LIMIT and DEFAULT_RENEG_WINDOW are defined in php_openssl.h if HAVE_OPENSSL_EXT is defined. HAVE_OPENSSL_EXT is defined to 1 in config.h. xp_ssl.c does #include php_openssl.h. So perhaps the problem is that config.h isn't being #included. I copied the lines to do that from openssl.c to xp_ssl.c, and now it builds successfully. The patch is attached. -- Edit bug report at https://bugs.php.net/bug.php?id=66840&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=66840&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=66840&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=66840&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=66840&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=66840&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=66840&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=66840&r=needscript Try newer version: https://bugs.php.net/fix.php?id=66840&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=66840&r=support Expected behavior: https://bugs.php.net/fix.php?id=66840&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=66840&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=66840&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=66840&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=66840&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=66840&r=dst IIS Stability: https://bugs.php.net/fix.php?id=66840&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=66840&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=66840&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=66840&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=66840&r=mysqlcfg