Bug #66840 [Com]: use of undeclared identifiers 'DEFAULT_RENEG_LIMIT', 'DEFAULT_RENEG_WINDOW'

Edit report at https://bugs.php.net/bug.php?id=66840&edit=1 ID: 66840 Comment by: rdlowrey@php.net Reported by: php-bugs-2014 at ryandesign dot com Summary: use of undeclared identifiers 'DEFAULT_RENEG_LIMIT', 'DEFAULT_RENEG_WINDOW' Status: Assigned Type: Bug Package: OpenSSL related Operating System: OS X 10.9.2 PHP Version: 5.6.0alpha3 Assigned To: rdlowrey Block user comment: N Private report: N New Comment: Sorry, I didn't see this report earlier. This should be fixed in 27849c998a from a few weeks ago: https://github.com/php/php-src/commit/27849c998a77a093449dec4b051dfc266d5123ec I've spoken with at least one person who has since built the extension on MacOS without issue. The beta1 release is building fine for me in windows and the few linux distros I've tested, though I do not have access to Mac to test specifically there. I'm closing the report for now (due to the reasons above). Please update this bug report if the issue persists for you with the beta1 release. Thanks again for the report and my apologies for not getting to it sooner! Previous Comments: ------------------------------------------------------------------------ [2014-04-13 20:40:54] rdlowrey@php.net Looking into it ... ------------------------------------------------------------------------ [2014-04-13 20:28:24] tyrael@php.net Daniel, could you look into this please? ------------------------------------------------------------------------ [2014-03-07 02:29:23] php-bugs-2014 at ryandesign dot com Description: ------------ Hello, I'm the maintainer of php in MacPorts. I'm trying to update our php56 ports to version 5.6.0alpha3. The openssl extension is failing to build, as follows: /opt/local/var/macports/build/_Users_rschmidt_macports_dports_lang_php/php56-openssl/work/php-5.6.0alpha3/ext/openssl/xp_ssl.c:390:15: error: use of undeclared identifier 'DEFAULT_RENEG_LIMIT' long limit = DEFAULT_RENEG_LIMIT; ^ /opt/local/var/macports/build/_Users_rschmidt_macports_dports_lang_php/php56-openssl/work/php-5.6.0alpha3/ext/openssl/xp_ssl.c:391:16: error: use of undeclared identifier 'DEFAULT_RENEG_WINDOW' long window = DEFAULT_RENEG_WINDOW; ^ 2 errors generated. make: *** [xp_ssl.lo] Error 1 Note that we're building the extension separately from php, using phpize and a separate configure and make. 5.6.0alpha2 built fine. DEFAULT_RENEG_LIMIT and DEFAULT_RENEG_WINDOW are defined in php_openssl.h if HAVE_OPENSSL_EXT is defined. HAVE_OPENSSL_EXT is defined to 1 in config.h. xp_ssl.c does #include php_openssl.h. So perhaps the problem is that config.h isn't being #included. I copied the lines to do that from openssl.c to xp_ssl.c, and now it builds successfully. The patch is attached. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=66840&edit=1