Bug #67064 [Csd]: Countable interface prevents using 2nd parameter ($mode) of count() function

From: Date: Fri, 13 Jun 2014 13:57:00 +0000
Subject: Bug #67064 [Csd]: Countable interface prevents using 2nd parameter ($mode) of count() function
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-186179@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=67064&edit=1

 ID:                 67064
 Updated by:         mbeccati@php.net
 Reported by:        trainmaster at gmx dot net
 Summary:            Countable interface prevents using 2nd parameter
                     ($mode) of count() function
 Status:             Closed
 Type:               Bug
 Package:            SPL related
 Operating System:   Windows 7 64 bit
 PHP Version:        Irrelevant
 Assigned To:        bwoebi
 Block user comment: N
 Private report:     N

 New Comment:

I've attached a patch that restores BC in the (very common) case when count() is called without
arguments, so that Countable::count() is called rather than Countable::count(0).

It's not a big deal, but the BC break might break the application tests that expect a call
without parameters. This would avoid having to do check for PHP 5.6 in such tests.


Previous Comments:
------------------------------------------------------------------------
[2014-06-13 13:53:01] mbeccati@php.net

The following patch has been added/updated:

Patch Name: bug67064-BC
Revision:   1402667581
URL:        https://bugs.php.net/patch-display.php?bug=67064&patch=bug67064-BC&revision=1402667581

------------------------------------------------------------------------
[2014-05-01 14:59:36] tyrael@php.net

Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1a4a9eede59b853f11e8e8b965e5f715f53da8f7
Log: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the
Countable interface to get the $mode passed to count().

------------------------------------------------------------------------
[2014-04-15 13:05:48] ab@php.net

Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1a4a9eede59b853f11e8e8b965e5f715f53da8f7
Log: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the
Countable interface to get the $mode passed to count().

------------------------------------------------------------------------
[2014-04-15 12:04:45] ab@php.net

Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1a4a9eede59b853f11e8e8b965e5f715f53da8f7
Log: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the
Countable interface to get the $mode passed to count().

------------------------------------------------------------------------
[2014-04-13 17:28:16] bwoebi@php.net

Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1a4a9eede59b853f11e8e8b965e5f715f53da8f7
Log: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the
Countable interface to get the $mode passed to count().

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=67064


--
Edit this bug report at https://bugs.php.net/bug.php?id=67064&edit=1


Thread (11 messages)

« previous php.bugs (#186179) next »