Edit report at https://bugs.php.net/bug.php?id=67064&edit=1
ID: 67064
Updated by: ab@php.net
Reported by: trainmaster at gmx dot net
Summary: Countable interface prevents using 2nd parameter
($mode) of count() function
-Status: Re-Opened
+Status: Closed
Type: Bug
Package: SPL related
Operating System: Windows 7 64 bit
PHP Version: Irrelevant
Assigned To: bwoebi
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=354ee12b73dbe20d0c4fa7883eb34714f89109df
Log: Revert "Fix bug #67064 in a BC safe way"
Previous Comments:
------------------------------------------------------------------------
[2014-07-30 18:40:45] tyrael@php.net
the fix was still causing some BC concerns, so we reverted it from PHP-5.6.
see http://www.serverphorums.com/read.php?7,988818
for the discussion leading to the revert.
------------------------------------------------------------------------
[2014-07-30 16:07:16] bwoebi@php.net
Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=354ee12b73dbe20d0c4fa7883eb34714f89109df
Log: Revert "Fix bug #67064 in a BC safe way"
------------------------------------------------------------------------
[2014-07-30 15:18:29] bwoebi@php.net
Automatic comment on behalf of bobwei9@hotmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=354ee12b73dbe20d0c4fa7883eb34714f89109df
Log: Revert "Fix bug #67064 in a BC safe way"
------------------------------------------------------------------------
[2014-06-13 16:42:54] bwoebi@php.net
I think this isn't preferable behavior. Maybe, with your patch BC is conserved in the most
strict sense, but it's not the least confusing way when using this feature, I think.
------------------------------------------------------------------------
[2014-06-13 13:57:00] mbeccati@php.net
I've attached a patch that restores BC in the (very common) case when count() is called without
arguments, so that Countable::count() is called rather than Countable::count(0).
It's not a big deal, but the BC break might break the application tests that expect a call
without parameters. This would avoid having to do check for PHP 5.6 in such tests.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=67064
--
Edit this bug report at https://bugs.php.net/bug.php?id=67064&edit=1