Bug #70112 [PATCH]: [RFE] Allow "dirname" to go up various time

Edit report at https://bugs.php.net/bug.php?id=70112&edit=1 ID: 70112 Patch added by: remi@php.net Reported by: remi@php.net Summary: [RFE] Allow "dirname" to go up various time Status: Open Type: Bug Package: Unknown/Other Function Operating System: irrevelant PHP Version: 7.0.0beta1 Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: 0003-improve-loop-condition-to-avoid-hang-on-large-value.patch Revision: 1437727140 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0003-improve-loop-condition-to-avoid-hang-on-large-value.patch&revision=1437727140 Previous Comments: ------------------------------------------------------------------------ [2015-07-22 13:58:31] rowan dot collins at gmail dot com Ah, that makes sense. English is particularly irrational when it comes to abbreviations, and tends to use fossilized Latinisms. We might say "no. 4", but probably not "what no. is that?", I guess because "no" is also a word... Anyway, +1 on including this feature, though I'm not sure if it should be 7.0 or 7.1 at this point. ------------------------------------------------------------------------ [2015-07-22 12:39:10] remi@php.net The following patch has been added/updated: Patch Name: 0002-rename-arg-nb-to-levels-frenchism.patch Revision: 1437568750 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0002-rename-arg-nb-to-levels-frenchism.patch&revision=1437568750 ------------------------------------------------------------------------ [2015-07-22 12:30:36] remi@php.net nb stands for number... but false friend from French, sorry. I fine with any other name, like "levels" ------------------------------------------------------------------------ [2015-07-22 12:19:49] rowan dot collins at gmail dot com Nice idea, but what on earth does "$nb" mean? I know parameter names of internal functions only really exist in documentation, and can be easily changed, but we might as well try to make it obvious. How about "$levels", or "$climb_levels", or spell out whatever "nb" stands for (I'm not being sarcastic, I'm genuinely not sure)? ------------------------------------------------------------------------ [2015-07-22 11:46:26] remi@php.net The following patch has been added/updated: Patch Name: 0001-Fix-70112-RFE-Allow-dirname-to-go-up-various-time.patch Revision: 1437565586 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0001-Fix-70112-RFE-Allow-dirname-to-go-up-various-time.patch&revision=1437565586 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=70112 -- Edit this bug report at https://bugs.php.net/bug.php?id=70112&edit=1