Bug #70112 [PATCH]: [RFE] Allow "dirname" to go up various time

Edit report at https://bugs.php.net/bug.php?id=70112&edit=1 ID: 70112 Patch added by: remi@php.net Reported by: remi@php.net Summary: [RFE] Allow "dirname" to go up various time Status: Open Type: Bug Package: Unknown/Other Function Operating System: irrevelant PHP Version: 7.0.0beta1 Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: 0001-Fix-70112-RFE-Allow-dirname-to-go-up-various-times.patch Revision: 1437836385 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0001-Fix-70112-RFE-Allow-dirname-to-go-up-various-times.patch&revision=1437836385 Previous Comments: ------------------------------------------------------------------------ [2015-07-24 21:47:50] ab@php.net Remi, as it turns to be a bit more complicated right now, here were my 2 cents. The usage with 1 == levels is the common case. The current functionality should reside under an if branch, the new functionality including the levels < 1 and other error check should reside under an else branch. Does it sound logic? Thanks Anatol ------------------------------------------------------------------------ [2015-07-24 16:02:25] jpauli@php.net I like it. I'm +1. It might be a little bit late to contribute it for 7.0, though it is very tiny and self contained. This is the PHP7 RMs decision now. ------------------------------------------------------------------------ [2015-07-24 08:39:00] remi@php.net The following patch has been added/updated: Patch Name: 0003-improve-loop-condition-to-avoid-hang-on-large-value.patch Revision: 1437727140 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0003-improve-loop-condition-to-avoid-hang-on-large-value.patch&revision=1437727140 ------------------------------------------------------------------------ [2015-07-22 13:58:31] rowan dot collins at gmail dot com Ah, that makes sense. English is particularly irrational when it comes to abbreviations, and tends to use fossilized Latinisms. We might say "no. 4", but probably not "what no. is that?", I guess because "no" is also a word... Anyway, +1 on including this feature, though I'm not sure if it should be 7.0 or 7.1 at this point. ------------------------------------------------------------------------ [2015-07-22 12:39:10] remi@php.net The following patch has been added/updated: Patch Name: 0002-rename-arg-nb-to-levels-frenchism.patch Revision: 1437568750 URL: https://bugs.php.net/patch-display.php?bug=70112&patch=0002-rename-arg-nb-to-levels-frenchism.patch&revision=1437568750 ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=70112 -- Edit this bug report at https://bugs.php.net/bug.php?id=70112&edit=1