Bug #71219 [NEW]: php's configure script incorrectly checks for ttyname_r availability

From: atoth at atoth dot sote dot hu Operating system: Linux (Gentoo Hardened) PHP version: 5.6.16 Package: *Compile Issues Bug Type: Bug Bug description:php's configure script incorrectly checks for ttyname_r availability Description: ------------ While PHP's configure script checks for ttyname_r it uses this code snippet: return ttyname_r(0, buf, 64) ? 1 : 0; Although ttyname returns a pointer to the fd's null-terminated pathname or NULL on error - ttyname_r behaves differently: it stores the pathname in a buffer and returns 0 on success or an error number. http://linux.die.net/man/3/ttyname_r Therefore the above cited check will report a failure upon success. Configure emits a messages about posix_ttyname being thread unsafe, despite ttyname_r is available. I suggest to change the test logic by taking into account the return values. I attach a trivial example patch below. Please note, that this minor issue affects both 5.6* and the new 7.0* branches. I could not select both branches for the report... -- Edit bug report at https://bugs.php.net/bug.php?id=71219&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=71219&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=71219&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=71219&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=71219&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=71219&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=71219&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=71219&r=needscript Try newer version: https://bugs.php.net/fix.php?id=71219&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=71219&r=support Expected behavior: https://bugs.php.net/fix.php?id=71219&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=71219&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=71219&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=71219&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=71219&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=71219&r=dst IIS Stability: https://bugs.php.net/fix.php?id=71219&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=71219&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=71219&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=71219&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=71219&r=mysqlcfg