Bug #71219 [Csd->ReO]: php's configure script incorrectly checks for ttyname_r availability

Edit report at https://bugs.php.net/bug.php?id=71219&edit=1 ID: 71219 Updated by: nikic@php.net Reported by: atoth at atoth dot sote dot hu Summary: php's configure script incorrectly checks for ttyname_r availability -Status: Closed +Status: Re-Opened Type: Bug Package: *Compile Issues Operating System: Linux (Gentoo Hardened) PHP Version: 5.6.16 Block user comment: N Private report: N New Comment: Someone messed the repo again, reopening. Previous Comments: ------------------------------------------------------------------------ [2016-10-17 10:10:17] bwoebi@php.net Automatic comment on behalf of nikic Revision: http://git.php.net/?p=php-src.git;a=commit;h=14d674442ef86ad4e862228a1ff5ecd322ae7759 Log: Fixed bug #71219 ------------------------------------------------------------------------ [2016-10-17 10:10:15] bwoebi@php.net Automatic comment on behalf of nikic Revision: http://git.php.net/?p=php-src.git;a=commit;h=c9d3ff0c6e86398b9471428ab49c6a6fa47ae977 Log: Revert "Fixed bug #71219" ------------------------------------------------------------------------ [2016-07-31 14:25:04] atoth at atoth dot sote dot hu I believe it's quite possible, that the given file descriptor specified in the fix works well only for Gentoo sandbox. Other environments can have another fd wining. Therefore the simple configure code snippet would not fit for all circumstances. One possibility is to test only for the availability of the symbol - as you've suggested. Otherwise the configure code must be more complex for this test. Please also note I'm just a power user and doesn't want to act like a smartass... ------------------------------------------------------------------------ [2016-07-30 16:39:41] nikic@php.net Sorry, I misunderstood the discussion and applied the incorrect fix. Reverted now. However the other proposed fix, using fd 1 instead of 0, does not work for me either. Might it be sufficient to just check for the availability of the ttyname_r symbol? ------------------------------------------------------------------------ [2016-07-30 16:36:53] nikic@php.net Automatic comment on behalf of nikic Revision: http://git.php.net/?p=php-src.git;a=commit;h=c9d3ff0c6e86398b9471428ab49c6a6fa47ae977 Log: Revert "Fixed bug #71219" ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=71219 -- Edit this bug report at https://bugs.php.net/bug.php?id=71219&edit=1