Bug #14522 Updated: Crash with using $node->unlink();

ID: 14522 Updated by: lukas@edeal.de Reported By: klebermass@limtec.de Status: Feedback Bug Type: DOM XML related Operating System: SuSe 7.3 PHP Version: CVS Download New Comment: derick, as of latest CVS (HEAD, php_domxml.c rev.1.120) a fix similar to the patch within this bug's history has already been committed by jtate (rev.1.119 was the last to crash on me) if you tested with latest head cvs, it's no wonder you dont see the php barf ;) Previous Comments: ------------------------------------------------------------------------ [2002-03-08 02:24:01] derick@php.net The script posted here does not crash for me with the latest CVS (27-03-2002). Can you try a snapshot from snaps.php.net? Derick ------------------------------------------------------------------------ [2002-03-07 18:53:46] jtate@php.net I've commented out the offending lines in the source. You can pull it from CVS at any time. I'll also see if we can get it into the 4.2.0 release. Thanks for bringing it up again. ------------------------------------------------------------------------ [2002-03-07 17:59:06] lukas@edeal.de beware: the bug is marked as closed, but a fix has not been applied to cvs yet. ------------------------------------------------------------------------ [2002-02-19 15:16:27] klebermass@limtec.de The patch from lukas@edeal.de worked on my Server. Hope it will be soon in the CVS Version ------------------------------------------------------------------------ [2002-02-19 13:43:50] lukas@edeal.de This patch against latest CVS should fix it: (basically it makes domxml not free a node on unlink and rather wait for request shutdown to free a node). btw, this patch also enables a domxml user to re-add a previously unlink()ed node, which is impossible with the current code. regards, -lukas Index: ext/domxml/php_domxml.c =================================================================== RCS file: /repository/php4/ext/domxml/php_domxml.c,v retrieving revision 1.116 diff -u -r1.116 php_domxml.c --- ext/domxml/php_domxml.c 4 Feb 2002 21:07:39 -0000 1.116 +++ ext/domxml/php_domxml.c 19 Feb 2002 18:38:57 -0000 @@ -1801,8 +1801,6 @@ DOMXML_PARAM_NONE(nodep, id, le_domxmlnodep); xmlUnlinkNode(nodep); - xmlFreeNode(nodep); - zval_dtor(id); /* This is not enough because the children won't be deleted */ } /* }}} */ ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/14522 -- Edit this bug report at http://bugs.php.net/?id=14522&edit=1