Bug #71753 [Asn]: Multiple (possible) mistakes in PHP "standard" extension code

Edit report at https://bugs.php.net/bug.php?id=71753&edit=1 ID: 71753 Updated by: laruence@php.net Reported by: temp at temp dot ru Summary: Multiple (possible) mistakes in PHP "standard" extension code Status: Assigned Type: Bug Package: *General Issues PHP Version: 7.0.4 Assigned To: ab Block user comment: N Private report: N New Comment: yeah, spl one is also fixed, thanks for the reporting, your help is appreciated :) Previous Comments: ------------------------------------------------------------------------ [2016-03-10 08:03:13] laruence@php.net hmm, so HANDLE is defined as unsigned... @welting what do you think? (I am not windows dever, so...) ------------------------------------------------------------------------ [2016-03-10 07:58:29] temp at temp dot ru And please also take a look at the first comment with similar SPL code issue. ------------------------------------------------------------------------ [2016-03-10 07:53:16] temp at temp dot ru The first one IS wrong, actually. Check this: http://codepad.org/Q0edKW9A ------------------------------------------------------------------------ [2016-03-10 07:31:21] laruence@php.net Hey: 1. it's not wrong, at least INVALID_HANDLE_VALUE === -1 2. not sure about this one. 3. fixed 4. fixed 5. fixed 6. not a problem, incomplete_class makes sure key is valid. ------------------------------------------------------------------------ [2016-03-09 12:28:26] temp at temp dot ru Also, there's similar possible bug in SPL: spl_dllist.c, spl_ptr_llist_destroy function: while (current) { next = current->next; // --> Access to current->next if(current && dtor) { // --> Later check if current is not null dtor(current); } ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=71753 -- Edit this bug report at https://bugs.php.net/bug.php?id=71753&edit=1