Bug #71753 [Asn->Csd]: Multiple (possible) mistakes in PHP "standard" extension code

From: Date: Fri, 11 Mar 2016 13:34:37 +0000
Subject: Bug #71753 [Asn->Csd]: Multiple (possible) mistakes in PHP "standard" extension code
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-199759@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=71753&edit=1

 ID:                 71753
 Updated by:         ab@php.net
 Reported by:        temp at temp dot ru
 Summary:            Multiple (possible) mistakes in PHP "standard"
                     extension code
-Status:             Assigned
+Status:             Closed
 Type:               Bug
 Package:            *General Issues
 PHP Version:        7.0.4
 Assigned To:        ab
 Block user comment: N
 Private report:     N

 New Comment:

Yeah, thanks for the proposals. The HANDLE issue is fixed now. That code was about 20 years old :)

Thanks.


Previous Comments:
------------------------------------------------------------------------
[2016-03-10 08:04:23] laruence@php.net

yeah, spl one is also fixed, thanks for the reporting, your help is appreciated  :)

------------------------------------------------------------------------
[2016-03-10 08:03:13] laruence@php.net

hmm, so HANDLE is defined as unsigned...

@welting what do you think? (I am not windows dever, so...)

------------------------------------------------------------------------
[2016-03-10 07:58:29] temp at temp dot ru

And please also take a look at the first comment with similar SPL code issue.

------------------------------------------------------------------------
[2016-03-10 07:53:16] temp at temp dot ru

The first one IS wrong, actually.

Check this: http://codepad.org/Q0edKW9A

------------------------------------------------------------------------
[2016-03-10 07:31:21] laruence@php.net

Hey:

    1. it's not wrong, at least INVALID_HANDLE_VALUE === -1
    2. not sure about this one.
    3. fixed
    4. fixed
    5. fixed
    6. not a problem, incomplete_class makes sure key is valid.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=71753


--
Edit this bug report at https://bugs.php.net/bug.php?id=71753&edit=1

Thread (8 messages)

« previous php.bugs (#199759) next »