Bug #72119 [Nab]: Interface declaration compatibility regression with default values

Edit report at https://bugs.php.net/bug.php?id=72119&edit=1 ID: 72119 Updated by: ab@php.net Reported by: ben dot davies at gmail dot com Summary: Interface declaration compatibility regression with default values Status: Not a bug Type: Bug Package: Scripting Engine problem PHP Version: 7.0.6 Assigned To: levim Block user comment: N Private report: N New Comment: We should not introduce such BC breaches in a minor release. This is really one of the basic OOP usage cases, the impact is unknown. I'd say keeping BC in this case is more important. Thanks. Previous Comments: ------------------------------------------------------------------------ [2016-04-28 16:58:39] dmitry@php.net Automatic comment on behalf of dmitry@zend.com Revision: http://git.php.net/?p=php-src.git;a=commit;h=9e45ac53ce64461e56f82f5847526a675c769f88 Log: Fixed BC break described by bug #72119. It was introduced after 7.0.5 release by attempt to fix bug #71428. ------------------------------------------------------------------------ [2016-04-28 16:50:50] rowan dot collins at gmail dot com Given that it has the potential to break existing code, I think it would make more sense to fix it in 7.1, when people will be expecting to check changelogs and update code. Breaking compatibility in a patch release will just lead to people not trusting the official releases, and thus not getting important security fixes, which is in nobody's interest. ------------------------------------------------------------------------ [2016-04-28 16:42:51] bwoebi@php.net Correct; it should never have worked in the first place though; While it technically is a BC break, I personally think this was in the first place an important (long-term) bugfix. [which thus shouldn't be reverted in 7.0.7] ------------------------------------------------------------------------ [2016-04-28 16:34:14] dmitry@php.net The original problem was introduced by attempt to fix #71428 (that expects exactly the opposite behavior) in commit ee9a78a033696ff9546fb1dbfecd28f20477b511 ------------------------------------------------------------------------ [2016-04-28 15:26:30] ben dot davies at gmail dot com Hi both, No doubt you are both correct, but this appears to be a BC break. This works in every version of php up to 7.0.6. https://3v4l.org/VhEtd Thanks ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=72119 -- Edit this bug report at https://bugs.php.net/bug.php?id=72119&edit=1