Bug #72119 [Nab->Csd]: Interface declaration compatibility regression with default values

From: Date: Thu, 28 Apr 2016 17:14:44 +0000
Subject: Bug #72119 [Nab->Csd]: Interface declaration compatibility regression with default values
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-200813@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=72119&edit=1

 ID:                 72119
 Updated by:         dmitry@php.net
 Reported by:        ben dot davies at gmail dot com
 Summary:            Interface declaration compatibility regression with
                     default values
-Status:             Not a bug
+Status:             Closed
 Type:               Bug
 Package:            Scripting Engine problem
 PHP Version:        7.0.6
-Assigned To:        levim
+Assigned To:        dmitry
 Block user comment: N
 Private report:     N

 New Comment:

The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------
[2016-04-28 17:07:21] ab@php.net

We should not introduce such BC breaches in a minor release. This is really one of the basic OOP
usage cases, the impact is unknown. I'd say keeping BC in this case is more important.

Thanks.

------------------------------------------------------------------------
[2016-04-28 16:58:39] dmitry@php.net

Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=9e45ac53ce64461e56f82f5847526a675c769f88
Log: Fixed BC break described by bug #72119. It was introduced after 7.0.5 release by attempt to fix
bug #71428.

------------------------------------------------------------------------
[2016-04-28 16:50:50] rowan dot collins at gmail dot com

Given that it has the potential to break existing code, I think it would make more sense to fix it
in 7.1, when people will be expecting to check changelogs and update code. Breaking compatibility in
a patch release will just lead to people not trusting the official releases, and thus not getting
important security fixes, which is in nobody's interest.

------------------------------------------------------------------------
[2016-04-28 16:42:51] bwoebi@php.net

Correct; it should never have worked in the first place though;
While it technically is a BC break, I personally think this was in the first place an important
(long-term) bugfix. [which thus shouldn't be reverted in 7.0.7]

------------------------------------------------------------------------
[2016-04-28 16:34:14] dmitry@php.net

The original problem was introduced by attempt to fix #71428 (that expects exactly the opposite
behavior) in commit ee9a78a033696ff9546fb1dbfecd28f20477b511

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=72119


--
Edit this bug report at https://bugs.php.net/bug.php?id=72119&edit=1


Thread (1 message)

  • dmitry@php.net
  • Unknown Message
    • dmitry@php.net
« previous php.bugs (#200813) next »