Bug #71924 [PATCH]: phpdbg fails to link with -lreadline

From: Date: Wed, 28 Sep 2016 12:30:32 +0000
Subject: Bug #71924 [PATCH]: phpdbg fails to link with -lreadline
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-204320@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=71924&edit=1

 ID:                 71924
 Patch added by:     mike@php.net
 Reported by:        bernd at bpj-code dot co dot za
 Summary:            phpdbg fails to link with -lreadline
 Status:             Feedback
 Type:               Bug
 Package:            Compile Failure
 Operating System:   Linux
 PHP Version:        7.0.x
 Block user comment: N
 Private report:     N

 New Comment:

The following patch has been added/updated:

Patch Name: phpdbg-readline-subst.diff
Revision:   1475065831
URL:        https://bugs.php.net/patch-display.php?bug=71924&patch=phpdbg-readline-subst.diff&revision=1475065831


Previous Comments:
------------------------------------------------------------------------
[2016-09-28 12:06:29] mike@php.net

The patch looks good to me, as far as I can tell.

Can you give a reasoning why you named the diversion BODY_POSTSELECT?

Also, I don't think we need to link against libreadline's dependencies; does phpdbg use
them directly?

------------------------------------------------------------------------
[2016-07-09 21:42:17] bernd at bpj-code dot co dot za

Updated patch so it actually causes the phpdbg Makefile fragment to get included, and to actually
add -lreadline.

------------------------------------------------------------------------
[2016-07-06 19:35:58] bernd at bpj-code dot co dot za

Same FTBFS in 7.0.8; not specific to 7.0.5, and not really (inherently) unique to phpdbg either.

------------------------------------------------------------------------
[2016-07-06 19:29:20] bernd at bpj-code dot co dot za

My configuration FWIW:

configured by ./configure, generated by GNU Autoconf 2.69,
  with options "'--with-libdir=lib/x86_64-linux-gnu'
'--with-apxs2=/usr/bin/apxs2'
'--with-config-file-path=/home/bernd/tor-inst/etc/php7'
'--with-config-file-scan-dir=/home/bernd/tor-inst/etc/php7/conf.d'
'--with-zlib=shared,/usr' '--enable-bcmath' '--with-bz2=shared'
'--enable-calendar' '--with-curl=shared,/usr' '--enable-dba=shared'
'--with-db4=shared,/usr' '--enable-exif' '--enable-ftp'
'--with-openssl=shared,/usr' '--with-iconv=shared'
'--with-mysqli=shared,/usr/bin/mysql_config'
'--with-mysql-sock=/var/run/mysqld/mysqld.sock' '--enable-pcntl'
'--with-pdo-mysql=shared' '--with-readline=shared,/usr'
'--enable-sockets' '--disable-static' '--with-gdbm=shared'
'--with-pcre-regex=/usr' '--disable-short-tags' '--enable-phpdbg'
'--enable-phpdbg-webhelper' '--enable-fpm'"

------------------------------------------------------------------------
[2016-03-30 01:23:43] bernd at bpj-code dot co dot za

Description:
------------
make recipe fails to include -lreadline (and also -lncurses or whatever readline depends on, for
that matter) when building SAPI artifacts.

sapi/phpdbg/config.m4 appears to attempt to link to -lreadline, as
PHPDBG_EXTRA_LIBS="$PHP_READLINE_LIBS", but I'm inferring that since sapi/*/config.m4
get config-stubs'ed before ext/*/config.m4, $PHP_READLINE_LIBS is not yet set when the phpdbg
configury runs.



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=71924&edit=1


Thread (8 messages)

« previous php.bugs (#204320) next »