Bug #71924 [Com]: phpdbg fails to link with -lreadline
Edit report at https://bugs.php.net/bug.php?id=71924&edit=1
ID: 71924
Comment by: bernd at bpj-code dot co dot za
Reported by: bernd at bpj-code dot co dot za
Summary: phpdbg fails to link with -lreadline
Status: No Feedback
Type: Bug
Package: Compile Failure
Operating System: Linux
PHP Version: 7.0.x
Block user comment: N
Private report: N
New Comment:
I could have sworn I provided the requested feedback... and I didn't see Mike's patch
either.
I'm not entirely happy with the name I chose for the diversion. Diversion 1000 is BODY, and the
BODY_POSTSELECT diversion needs to be undiverted "nearby": after all feature-selection
script output, but before generating any output files, since these output files could conceivably
need to contain text computed from feature selections.
And worse, autoconf diversions are rather underdocumented.
IIRC libreadline is (was?) special in that it could dynamically link with either libncurses or
libterminfo (or something like that) and relied on its client program to choose which indirect
dependency to link to.
Unfortunately Mike's patch doesn't work for me, for a different reason: now it's -lz
that's missing from the link line. (This time it's mysqlnd that wants -lz. Not too long
ago ld(1) would pick up DT_NEEDED: libz.so.N from the many libraries phpdbg does get linked to
explicitly, but newer versions use only explicitly named libraries.)
Previous Comments:
------------------------------------------------------------------------
[2016-10-09 04:22:31] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
------------------------------------------------------------------------
[2016-09-28 12:30:32] mike@php.net
The following patch has been added/updated:
Patch Name: phpdbg-readline-subst.diff
Revision: 1475065831
URL: https://bugs.php.net/patch-display.php?bug=71924&patch=phpdbg-readline-subst.diff&revision=1475065831
------------------------------------------------------------------------
[2016-09-28 12:06:29] mike@php.net
The patch looks good to me, as far as I can tell.
Can you give a reasoning why you named the diversion BODY_POSTSELECT?
Also, I don't think we need to link against libreadline's dependencies; does phpdbg use
them directly?
------------------------------------------------------------------------
[2016-07-09 21:42:17] bernd at bpj-code dot co dot za
Updated patch so it actually causes the phpdbg Makefile fragment to get included, and to actually
add -lreadline.
------------------------------------------------------------------------
[2016-07-06 19:35:58] bernd at bpj-code dot co dot za
Same FTBFS in 7.0.8; not specific to 7.0.5, and not really (inherently) unique to phpdbg either.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=71924
--
Edit this bug report at https://bugs.php.net/bug.php?id=71924&edit=1
Thread (8 messages)