Req #65038 [Com]: IMAGETYPE_WEBP constant missing

Edit report at https://bugs.php.net/bug.php?id=65038&edit=1 ID: 65038 Comment by: bluespire at gmail dot com Reported by: david at admin dot amateri dot cz Summary: IMAGETYPE_WEBP constant missing Status: Closed Type: Feature/Change Request Package: GetImageSize related Operating System: CentOS 6 PHP Version: 5.5.0RC3 Assigned To: cmb Block user comment: N Private report: N New Comment: Is there any chance this patch would be accepted into the 5.6 branch? Not all of us are able to move directly to 7.1 to take advantage of this, and other webp supporting functions like imagecreatewebp are in 5.5+ Previous Comments: ------------------------------------------------------------------------ [2016-10-08 13:15:56] cmb@php.net VP8X support added with commit <http://git.php.net/?p=php-src.git;a=commit;h=1d977e55>. ------------------------------------------------------------------------ [2016-10-08 11:33:33] cmb@php.net > Of course it depends on whether imagecreatefromwebp supports > VP8X or not. Not necessarily; for instance, getimagesize() supports BMP, but GD still doesn't. Anyhow, as I've just learned imagecreatefromwebp() does support VP8X (even stored color profiles are applied), so it makes indeed sense to add support for VP8X to getimagesize(). ------------------------------------------------------------------------ [2016-10-08 09:39:59] enumag at gmail dot com Very nice! :-) Now is there a reason not to implement VP8X as well? It seems that the "Canvas Width Minus One" and "Canvas Height Minus One" are always at the same position so it should be easy. https://developers.google.com/speed/webp/docs/riff_container#extended_file_format Of course it depends on whether imagecreatefromwebp supports VP8X or not. ------------------------------------------------------------------------ [2016-10-08 08:55:56] cmb@php.net VP8L support implemented with <http://git.php.net/?p=php-src.git;a=commit;h=59cd8eb7>. ------------------------------------------------------------------------ [2016-10-08 07:32:50] cmb@php.net > Does it mean that if I call getimagesize on a lossless webp it > won't return the needed info? Indeed, getimagesize() would return FALSE in this case. Actually, I thought that lossless WebP isn't very common and that it wouldn't be supported by libgd, but at least the latter assumption was wrong – imagecreatefromwebp() is able to read lossless WebP (at least the simple format without alpha; haven't yet checked further). So it makes sense to add support for simple lossless WebP (VP8L) to getimagesize() and friends. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=65038 -- Edit this bug report at https://bugs.php.net/bug.php?id=65038&edit=1