Req #65038 [Csd]: IMAGETYPE_WEBP constant missing

From: Date: Fri, 18 Nov 2016 10:10:05 +0000
Subject: Req #65038 [Csd]: IMAGETYPE_WEBP constant missing
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-205444@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=65038&edit=1

 ID:                 65038
 Updated by:         cmb@php.net
 Reported by:        david at admin dot amateri dot cz
 Summary:            IMAGETYPE_WEBP constant missing
 Status:             Closed
 Type:               Feature/Change Request
 Package:            GetImageSize related
 Operating System:   CentOS 6
 PHP Version:        5.5.0RC3
 Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

> Is there any chance this patch would be accepted into the 5.6
> branch?

This ticket had been rightly filed as feature request, and we
usually don't add new features to stable branches for QA reasons.
Note also that active support for PHP 5.6 ends in about 6 weeks,
so it's rather unlikely that this patch will be backported to 5.6.

If you really have to stick with PHP 5.6 for now, consider a
userland implementation. If you only have to detect whether a file
is in WebP format, it should be sufficient to check whether the
first three bytes of the file are VP8.


Previous Comments:
------------------------------------------------------------------------
[2016-11-17 22:57:21] bluespire at gmail dot com

Is there any chance this patch would be accepted into the 5.6 branch?

Not all of us are able to move directly to 7.1 to take advantage of this, and other webp supporting
functions like imagecreatewebp are in 5.5+

------------------------------------------------------------------------
[2016-10-08 13:15:56] cmb@php.net

VP8X support added with commit <http://git.php.net/?p=php-src.git;a=commit;h=1d977e55>.

------------------------------------------------------------------------
[2016-10-08 11:33:33] cmb@php.net

> Of course it depends on whether imagecreatefromwebp supports
> VP8X or not.

Not necessarily; for instance, getimagesize() supports BMP, but
GD still doesn't.

Anyhow, as I've just learned imagecreatefromwebp() does support
VP8X (even stored color profiles are applied), so it makes indeed
sense to add support for VP8X to getimagesize().

------------------------------------------------------------------------
[2016-10-08 09:39:59] enumag at gmail dot com

Very nice! :-)

Now is there a reason not to implement VP8X as well? It seems that the "Canvas Width Minus
One" and "Canvas Height Minus One" are always at the same position so it should be
easy. https://developers.google.com/speed/webp/docs/riff_container#extended_file_format

Of course it depends on whether imagecreatefromwebp supports VP8X or not.

------------------------------------------------------------------------
[2016-10-08 08:55:56] cmb@php.net

VP8L support implemented with <http://git.php.net/?p=php-src.git;a=commit;h=59cd8eb7>.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=65038


--
Edit this bug report at https://bugs.php.net/bug.php?id=65038&edit=1


Thread (16 messages)

« previous php.bugs (#205444) next »