Bug #70492 [Csd->ReO]: compile errors Solaris10/Studio12.1 (with fixes)

Edit report at https://bugs.php.net/bug.php?id=70492&edit=1 ID: 70492 Updated by: nikic@php.net Reported by: hsk at imb-jena dot de Summary: compile errors Solaris10/Studio12.1 (with fixes) -Status: Closed +Status: Re-Opened Type: Bug Package: Compile Failure Operating System: Solaris10 PHP Version: 7.0.1 Block user comment: N Private report: N New Comment: I've applied the fixes for zend_alloc and phpdbg. I haven't applied the libmagic change yet, because I'm not sure if this is the right place to do it. We explicitly patch out an stddef.h include from upstream. I assume that this is done because we already include stddef.h at an earlier point anyway. This include happens in https://github.com/php/php-src/blob/452dcf12ae3376a3cdb47490c51aadb0651a2a73/Zend/zend_operators.h#L30 behind a __GNUC__ guard, which is why it is skipped on Solaris. Seeing how https://github.com/php/php-src/blob/452dcf12ae3376a3cdb47490c51aadb0651a2a73/Zend/zend_strtod_int.h#L26 includes stddef.h without any guards, we already assume this header is always available. As such, we should be able to just drop the __GNUC__ guard on the include in zend_operators.h. Previous Comments: ------------------------------------------------------------------------ [2016-12-14 17:12:42] nikic@php.net Automatic comment on behalf of nikic Revision: http://git.php.net/?p=php-src.git;a=commit;h=f99bf7036033f4dd95b8f56c8697af7f8963ab9f Log: Partially fix bug #70492 ------------------------------------------------------------------------ [2016-02-09 12:07:11] alex dot collins at anglia dot ac dot uk Building PhP 7.0.3 on Solaris 11.3 X86 with Studio 12.3 Patch is required and works. No Further issues experienced. ------------------------------------------------------------------------ [2015-12-18 11:34:34] hsk at imb-jena dot de supplied patch still needed for 7.0.1 to get 7.0.1 compiled on solaris 10 (patched up-to-current) using solaris-studio 12.4 ------------------------------------------------------------------------ [2015-12-17 19:48:24] stadtkind2 at gmx dot de PHP 7.0.1 compiles fine with your patch on Solaris 11.3 x86 + Solaris Studio 12.5 beta Thanks! ------------------------------------------------------------------------ [2015-10-12 12:52:32] felipe@php.net phpdbg's function is not a void one, actually it returns void*. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=70492 -- Edit this bug report at https://bugs.php.net/bug.php?id=70492&edit=1