Bug #70492 [ReO->Fbk]: compile errors Solaris10/Studio12.1 (with fixes)

From: Date: Mon, 31 May 2021 13:49:06 +0000
Subject: Bug #70492 [ReO->Fbk]: compile errors Solaris10/Studio12.1 (with fixes)
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-234115@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=70492&edit=1

 ID:                 70492
 Updated by:         cmb@php.net
 Reported by:        hsk at imb-jena dot de
 Summary:            compile errors Solaris10/Studio12.1 (with fixes)
-Status:             Re-Opened
+Status:             Feedback
 Type:               Bug
 Package:            Compile Failure
 Operating System:   Solaris10
 PHP Version:        7.0.1
-Assigned To:        
+Assigned To:        cmb
 Block user comment: N
 Private report:     N

 New Comment:

If there are still unresolved issues, could an affected user
please provide a pull request[1] for better visibility?

[1] <https://github.com/php/php-src/pulls>


Previous Comments:
------------------------------------------------------------------------
[2017-03-06 19:18:14] stadtkind2 at gmx dot de

@nikic I could test it on Solaris 11/SPARC with Developer Studio 12.5; just give me a patch :)

------------------------------------------------------------------------
[2016-12-14 17:19:08] nikic@php.net

I've applied the fixes for zend_alloc and phpdbg.

I haven't applied the libmagic change yet, because I'm not sure if this is the right place
to do it. We explicitly patch out an stddef.h include from upstream. I assume that this is done
because we already include stddef.h at an earlier point anyway. This include happens in https://github.com/php/php-src/blob/452dcf12ae3376a3cdb47490c51aadb0651a2a73/Zend/zend_operators.h#L30
behind a __GNUC__ guard, which is why it is skipped on Solaris. Seeing how https://github.com/php/php-src/blob/452dcf12ae3376a3cdb47490c51aadb0651a2a73/Zend/zend_strtod_int.h#L26
includes stddef.h without any guards, we already assume this header is always available. As such, we
should be able to just drop the __GNUC__ guard on the include in zend_operators.h.

------------------------------------------------------------------------
[2016-12-14 17:12:42] nikic@php.net

Automatic comment on behalf of nikic
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f99bf7036033f4dd95b8f56c8697af7f8963ab9f
Log: Partially fix bug #70492

------------------------------------------------------------------------
[2016-02-09 12:07:11] alex dot collins at anglia dot ac dot uk

Building PhP 7.0.3 on Solaris 11.3 X86 with Studio 12.3
Patch is required and works. No Further issues experienced.

------------------------------------------------------------------------
[2015-12-18 11:34:34] hsk at imb-jena dot de

supplied patch still needed for 7.0.1 to get 7.0.1 compiled on solaris 10 (patched up-to-current)
using solaris-studio 12.4

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=70492


--
Edit this bug report at https://bugs.php.net/bug.php?id=70492&edit=1


Thread (11 messages)

« previous php.bugs (#234115) next »