Bug #75269 [Opn]: mb_​regex_​encoding() does not support GB18030 or CP1251

From: Date: Thu, 28 Sep 2017 11:01:30 +0000
Subject: Bug #75269 [Opn]: mb_​regex_​encoding() does not support GB18030 or CP1251
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-211413@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=75269&edit=1

 ID:                 75269
 Updated by:         cmb@php.net
 Reported by:        gerthaubrich at web dot de
 Summary:            mb_​regex_​encoding() does not support GB18030
                     or CP1251
 Status:             Open
 Type:               Bug
 Package:            mbstring related
 Operating System:   Debain 8 x64
 PHP Version:        Irrelevant
 Block user comment: N
 Private report:     N

 New Comment:

> How does the function check for a valid/supported encoding name in PHP? Is the
> request passed through to the library itself, or is there some kind of 
> whitelist implemented in PHP before the function call (that hasn't been
> updated for quiet some time)?

From a quick glance, it looks like the latter, see
<https://lxr.room11.org/xref/php-src%40master/ext/mbstring/php_mbregex.c#enc_name_map>.


Previous Comments:
------------------------------------------------------------------------
[2017-09-27 21:21:51] gerthaubrich at web dot de

Description:
------------
Is there a reason why mb_​regex_​encoding() (and Oniguruma library) does not support
CP1251 and GB18030 in PHP? (Because general mbstring functions do support these encodings.)

I have checked PHP 5.4.45 (Oniguruma 4.7.1) up to PHP 7.0.23 and 7.1.9 (5.9.6) and now also 7.2.0
RC2 (6.3.0) and the function always accepts the same list of encodings over all these different
library versions.
According to Oniguruma history, support for GB18030 has been implemented in v3.8.4 and support for
CP1251 (alias Windows-1251) has been implemented in v5.2.0 of the library.

So I am wondering if this is a feature request or a bug in PHP?
How does the function check for a valid/supported encoding name in PHP? Is the request passed
through to the library itself, or is there some kind of whitelist implemented in PHP before the
function call (that hasn't been updated for quiet some time)?

Bug #23470 (05/2003 !) mentions option --enable-mbstring=all for CP1251, but this "all"
value has never been mentioned in the latest configure scripts, I remember (e.g. the last 3 years or
so). Does it still exist?

For example the 7.2.0 RC2 source contains in \ext\mbstring\oniguruma\src also the files cp1251.c and
gb18030.c, which are also referenced in config.w32 and in config.m4 and oniguruma.h defines
ONIG_ENCODING_CP1251 and ONIG_ENCODING_GB18030.



One additional thought for PHP 7.2:
Maybe the team should consider to bump the Oniguruma version to at least version 6.4.0, instead of
6.3.0. The history mentions fixed memory leaks and a "endless repeat" error for 6.4.0 and
only a few new features.

BR



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=75269&edit=1

Thread (4 messages)

« previous php.bugs (#211413) next »