Bug #75284 [Ver]: sha3 is not supported on bigendian machine
| From: | remi@php.net | Date: | Mon, 02 Oct 2017 11:59:48 +0000 |
| Subject: | Bug #75284 [Ver]: sha3 is not supported on bigendian machine | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-211489@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=75284&edit=1
ID: 75284
Updated by: remi@php.net
Reported by: remi@php.net
Summary: sha3 is not supported on bigendian machine
Status: Verified
Type: Bug
Package: hash related
Operating System: GNU/Linux
PHP Version: 7.2.0RC3
Block user comment: N
Private report: N
New Comment:
@Sara you proposal build but test suite fails.
(more info in the PR)
Previous Comments:
------------------------------------------------------------------------
[2017-09-29 19:26:04] pollita@php.net
Could you try this diff on a 64-bit BE machine? I don't have any handy. :D
https://gist.github.com/sgolemon/c79bb083b26b142867a09363458f5506
------------------------------------------------------------------------
[2017-09-29 11:38:43] remi@php.net
Description:
------------
At least on s390x and ppc64
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c: In function
'KeccakP1600_AddLanes':
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c:158:22: warning:
initialization discards 'const' qualifier from pointer target type
[-Wdiscarded-qualifiers]
UINT8 *curData = data;
^~~~
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c: In function
'KeccakP1600_OverwriteBytesInLane':
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c:208:2: error:
#error "Not yet implemented"
#error "Not yet implemented"
^~~~~
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c: In function
'KeccakP1600_OverwriteLanes':
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c:229:2: error:
#error "Not yet implemented"
#error "Not yet implemented"
^~~~~
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c: In function
'KeccakP1600_OverwriteWithZeroes':
/builddir/build/BUILD/php-7.2.0RC3/ext/hash/sha3/generic64lc/KeccakP-1600-opt64.c:264:2: error:
#error "Not yet implemented"
#error "Not yet implemented"
^~~~~
make: *** [Makefile:1073: ext/hash/sha3/generic64lc/KeccakP-1600-opt64.lo] Error 1
make: *** Waiting for unfinished jobs....
So we need to disable the new sha3 on bigendian
(at least temporarily until fully implemented)
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=75284&edit=1